Skip to content

Don't use dependency injection decoration for plugin profiling #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2017
Merged

Don't use dependency injection decoration for plugin profiling #193

merged 1 commit into from
Jul 17, 2017

Conversation

fbourigault
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #191
Documentation n/a
License MIT

This fix #191 by no longer use Symfony dependency injection decoration for plugin profiling.

Nyholm
Nyholm requested changes Jul 17, 2017
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must also make sure that $pluginServiceId.'.debug' is used in the plugin client.

@fbourigault
Copy link
Contributor Author

You are right! I was in a hurry to fix this and tests are green... I will try to add one!

@fbourigault
Copy link
Contributor Author

Fixed!

Nyholm
Nyholm approved these changes Jul 17, 2017
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 029fca1 into php-http:master Jul 17, 2017
@fbourigault fbourigault deleted the issue-191 branch July 17, 2017 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiling hide original service definition
2 participants
@fbourigault @Nyholm