Skip to content

Register routes sf 4.1 style #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2018
Merged

Register routes sf 4.1 style #270

merged 3 commits into from
Jun 29, 2018

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jun 28, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

What's in this PR?

Symfony 4.1 has deprecated the single colon syntax when defining routes.

dbu
dbu approved these changes Jun 29, 2018
View reviewed changes
Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks korrekt to me. i think the test failures are not related to these changes.

@dbu dbu merged commit 457b016 into master Jun 29, 2018
@dbu dbu deleted the patch-routes branch June 29, 2018 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @dbu