Feedback fixes

Author: acrobat

src/CachePlugin.php

@@ -91,7 +91,7 @@ public static function clientCache(CacheItemPoolInterface $pool, StreamFactory $
         if (isset($config['respect_response_cache_directives'])) {
             $config['respect_response_cache_directives'][] = 'no-cache';
             $config['respect_response_cache_directives'][] = 'max-age';
-            array_unique($config['respect_response_cache_directives']);
+            $config['respect_response_cache_directives'] = array_unique($config['respect_response_cache_directives']);
         } else {
             $config['respect_response_cache_directives'] = ['no-cache', 'max-age'];
         }
@@ -240,9 +240,9 @@ protected function isCacheable(ResponseInterface $response)
             return false;
         }
 
-        $cacheableDirectives = $this->extractDirectives($this->config['respect_response_cache_directives'], $this->noCacheFlags);
-        foreach ($cacheableDirectives as $cacheableDirective) {
-            if ($this->getCacheControlDirective($response, $cacheableDirective)) {
+        $nocacheDirectives = array_intersect($this->config['respect_response_cache_directives'], $this->noCacheFlags);
+        foreach ($nocacheDirectives as $nocacheDirective) {
+            if ($this->getCacheControlDirective($response, $nocacheDirective)) {
                 return false;
             }
         }
@@ -431,9 +431,4 @@ private function getETag(CacheItemInterface $cacheItem)
             }
         }
     }
-
-    private function extractDirectives($directives, $extractDirectivesList)
-    {
-        return array_intersect($directives, $extractDirectivesList);
-    }
 }