Fix all remaining client signatures

Author: Jean85

spec/HttpClientPool/LeastUsedClientPoolSpec.php

@@ -72,10 +72,6 @@ public function it_reenable_client(HttpClient $client, RequestInterface $request
 
     public function it_uses_the_lowest_request_client(HttpClientPoolItem $client1, HttpClientPoolItem $client2, RequestInterface $request, ResponseInterface $response)
     {
-        if (extension_loaded('xdebug')) {
-            throw new SkippingException('This test fail when xdebug is enable on PHP < 7');
-        }
-
         $this->addHttpClient($client1);
         $this->addHttpClient($client2);
 

src/BatchClient.php

@@ -6,6 +6,7 @@
 use Http\Client\HttpClient;
 use Http\Client\Common\Exception\BatchException;
 use Psr\Http\Message\RequestInterface;
+use Psr\Http\Message\ResponseInterface;
 
 /**
  * BatchClient allow to sends multiple request and retrieve a Batch Result.
@@ -32,7 +33,7 @@ public function __construct(HttpClient $client)
     /**
      * {@inheritdoc}
      */
-    public function sendRequest(RequestInterface $request)
+    public function sendRequest(RequestInterface $request): ResponseInterface
     {
         return $this->client->sendRequest($request);
     }

src/HttpAsyncClientEmulator.php

@@ -5,6 +5,7 @@
 use Http\Client\Exception;
 use Http\Client\Promise;
 use Psr\Http\Message\RequestInterface;
+use Psr\Http\Message\ResponseInterface;
 
 /**
  * Emulates an HTTP Async Client in an HTTP Client.
@@ -18,7 +19,7 @@ trait HttpAsyncClientEmulator
      *
      * @see HttpClient::sendRequest
      */
-    abstract public function sendRequest(RequestInterface $request);
+    abstract public function sendRequest(RequestInterface $request): ResponseInterface;
 
     /**
      * {@inheritdoc}

src/HttpClientDecorator.php

@@ -4,6 +4,7 @@
 
 use Http\Client\HttpClient;
 use Psr\Http\Message\RequestInterface;
+use Psr\Http\Message\ResponseInterface;
 
 /**
  * Decorates an HTTP Client.
@@ -22,7 +23,7 @@ trait HttpClientDecorator
      *
      * @see HttpClient::sendRequest
      */
-    public function sendRequest(RequestInterface $request)
+    public function sendRequest(RequestInterface $request): ResponseInterface
     {
         return $this->httpClient->sendRequest($request);
     }

src/HttpClientEmulator.php

@@ -3,6 +3,7 @@
 namespace Http\Client\Common;
 
 use Psr\Http\Message\RequestInterface;
+use Psr\Http\Message\ResponseInterface;
 
 /**
  * Emulates an HTTP Client in an HTTP Async Client.
@@ -16,7 +17,7 @@ trait HttpClientEmulator
      *
      * @see HttpClient::sendRequest
      */
-    public function sendRequest(RequestInterface $request)
+    public function sendRequest(RequestInterface $request): ResponseInterface
     {
         $promise = $this->sendAsyncRequest($request);
 

src/HttpClientPool.php

@@ -6,6 +6,7 @@
 use Http\Client\HttpAsyncClient;
 use Http\Client\HttpClient;
 use Psr\Http\Message\RequestInterface;
+use Psr\Http\Message\ResponseInterface;
 
 /**
  * A http client pool allows to send requests on a pool of different http client using a specific strategy (least used,
@@ -52,7 +53,7 @@ public function sendAsyncRequest(RequestInterface $request)
     /**
      * {@inheritdoc}
      */
-    public function sendRequest(RequestInterface $request)
+    public function sendRequest(RequestInterface $request): ResponseInterface
     {
         return $this->chooseHttpClient()->sendRequest($request);
     }

src/HttpClientPoolItem.php

@@ -6,6 +6,7 @@
 use Http\Client\HttpClient;
 use Psr\Http\Message\RequestInterface;
 use Http\Client\Exception;
+use Psr\Http\Message\ResponseInterface;
 
 /**
  * A HttpClientPoolItem represent a HttpClient inside a Pool.
@@ -50,7 +51,7 @@ public function __construct($client, $reenableAfter = null)
     /**
      * {@inheritdoc}
      */
-    public function sendRequest(RequestInterface $request)
+    public function sendRequest(RequestInterface $request): ResponseInterface
     {
         if ($this->isDisabled()) {
             throw new Exception\RequestException('Cannot send the request as this client has been disabled', $request);

src/HttpClientRouter.php

@@ -7,6 +7,7 @@
 use Http\Client\HttpClient;
 use Http\Message\RequestMatcher;
 use Psr\Http\Message\RequestInterface;
+use Psr\Http\Message\ResponseInterface;
 
 /**
  * Route a request to a specific client in the stack based using a RequestMatcher.
@@ -23,7 +24,7 @@ final class HttpClientRouter implements HttpClient, HttpAsyncClient
     /**
      * {@inheritdoc}
      */
-    public function sendRequest(RequestInterface $request)
+    public function sendRequest(RequestInterface $request): ResponseInterface
     {
         $client = $this->chooseHttpClient($request);
 

src/PluginClient.php

@@ -9,6 +9,7 @@
 use Http\Client\Promise\HttpFulfilledPromise;
 use Http\Client\Promise\HttpRejectedPromise;
 use Psr\Http\Message\RequestInterface;
+use Psr\Http\Message\ResponseInterface;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
@@ -67,7 +68,7 @@ public function __construct($client, array $plugins = [], array $options = [])
     /**
      * {@inheritdoc}
      */
-    public function sendRequest(RequestInterface $request)
+    public function sendRequest(RequestInterface $request): ResponseInterface
     {
         // If we don't have an http client, use the async call
         if (!($this->client instanceof HttpClient)) {