Minor cleanup #162
Merged
Minor cleanup #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Jan 20, 2019
src/Deferred.php
Outdated
| @@ -14,15 +14,10 @@ | |||
| final class Deferred implements Promise | |||
| { | |||
| private $value; | |||
|
|
|||
There was a problem hiding this comment.
imho it would make sense to have phpdoc for the types of all fields here.
dbu
reviewed
Jan 20, 2019
src/Deferred.php
Outdated
| private $value; | ||
|
|
||
| /** | ||
| * @var Exception|null |
There was a problem hiding this comment.
should this be Psr\Http\Client\ClientExceptionInterface ? (i see that for now the type declaration in the method is the httplug exception interface, but psr exception would be future proof...
dbu
approved these changes
Jan 21, 2019
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.