Skip to content

Commit 3337029

Browse files
committed
#13: Remove HeaderParser
1 parent 5fbbcb8 commit 3337029

File tree

8 files changed

+13
-168
lines changed

8 files changed

+13
-168
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# Change Log
22

3+
## Unreleased
4+
5+
### Removed
6+
7+
- #13: Remove HeaderParser.
8+
9+
310
## 1.1.0 - 2016-01-29
411

512
### Changed

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"require-dev": {
2222
"guzzlehttp/psr7": "^1.0",
2323
"php-http/adapter-integration-tests": "dev-master#836cdff8294174cceeae54601ab4079c309227b7",
24-
"php-http/message": "^1.0",
24+
"php-http/message": "dev-master",
2525
"phpunit/phpunit": "^4.8",
2626
"zendframework/zend-diactoros": "^1.0"
2727
},

src/ResponseParser.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
namespace Http\Client\Curl;
33

4-
use Http\Client\Curl\Tools\HeadersParser;
4+
use Http\Message\Builder\ResponseBuilder;
55
use Http\Message\MessageFactory;
66
use Http\Message\StreamFactory;
77
use Psr\Http\Message\ResponseInterface;
@@ -50,6 +50,7 @@ public function __construct(MessageFactory $messageFactory, StreamFactory $strea
5050
* @return ResponseInterface
5151
*
5252
* @throws \InvalidArgumentException
53+
* @throws \UnexpectedValueException
5354
* @throws \RuntimeException
5455
*/
5556
public function parse($raw, array $info)
@@ -59,8 +60,9 @@ public function parse($raw, array $info)
5960
$headerSize = $info['header_size'];
6061
$rawHeaders = substr($raw, 0, $headerSize);
6162

62-
$parser = new HeadersParser();
63-
$response = $parser->parseString($rawHeaders, $response);
63+
$builder = new ResponseBuilder($response);
64+
$builder->setHeadersFromString($rawHeaders);
65+
$response = $builder->getResponse();
6466

6567
/*
6668
* substr can return boolean value for empty string. But createStream does not support

src/Tools/HeadersParser.php

Lines changed: 0 additions & 88 deletions
This file was deleted.

tests/Tools/HeadersParserTest.php

Lines changed: 0 additions & 66 deletions
This file was deleted.

tests/Tools/data/headers_invalid_header.http

Lines changed: 0 additions & 2 deletions
This file was deleted.

tests/Tools/data/headers_invalid_status.http

Lines changed: 0 additions & 4 deletions
This file was deleted.

tests/Tools/data/headers_valid.http

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)