Skip to content

Declare strict types #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2018
Merged

Declare strict types #47

merged 1 commit into from
Nov 28, 2018

Conversation

gmponos
Copy link
Contributor

@gmponos gmponos commented Nov 27, 2018 •
edited
Loading

As the title says

dbu
dbu approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

this will go into the 2.0 release once we tag that. which is fine, as there is a risk of borderline BC breaks with sloppy types by consumers (see #48 for example)

@dbu dbu merged commit 9f7923e into php-http:master Nov 28, 2018
@gmponos gmponos deleted the strict_types branch November 28, 2018 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmponos @dbu