Do not suggest installation of puli via composer or error messages

Author: naderman

composer.json

@@ -21,7 +21,6 @@
         "puli/composer-plugin": "1.0.0-beta10"
     },
     "suggest": {
-        "puli/composer-plugin": "Sets up Puli which is recommended for Discovery to work. Check http://docs.php-http.org/en/latest/discovery.html for more details.",
         "php-http/message": "Allow to use Guzzle, Diactoros or Slim Framework factories"
     },
     "autoload": {

src/ClassDiscovery.php

@@ -27,6 +27,10 @@ abstract class ClassDiscovery
         Strategy\CommonPsr17ClassesStrategy::class,
     ];
 
+    private static $deprecatedStrategies = [
+        Strategy\PuliBetaStrategy::class => true,
+    ];
+
     /**
      * Discovery cache to make the second time we use discovery faster.
      *
@@ -54,8 +58,10 @@ protected static function findOneByType($type)
         foreach (self::$strategies as $strategy) {
             try {
                 $candidates = call_user_func($strategy.'::getCandidates', $type);
-            } catch (StrategyUnavailableException $e) {
-                $exceptions[] = $e;
+	    } catch (StrategyUnavailableException $e) {
+                if (!isset(self::$deprecatedStrategies[$strategy])) {
+                    $exceptions[] = $e;
+                }
 
                 continue;
             }

tests/Exception/InitializeExceptionTest.php

@@ -11,7 +11,6 @@ public function testInitialize()
     {
         $e[] = new DiscoveryException\ClassInstantiationFailedException();
         $e[] = new DiscoveryException\NotFoundException();
-        $e[] = new DiscoveryException\PuliUnavailableException();
         $e[] = new DiscoveryException\StrategyUnavailableException();
         $e[] = new DiscoveryException\NoCandidateFoundException('CommonClasses', []);
         $e[] = DiscoveryException\DiscoveryFailedException::create($e);