Add back NotFoundException for BC (#69)

* Add back NotFoundException for BC

* Applied fixes from StyleCI (#70)

* Remove error trigger

* Change typehints to new exception

* Update changelog

* Add final notice

Author: sagikazarmark

CHANGELOG.md

@@ -3,10 +3,18 @@
 
 ## UNRELEASED
 
+### Added
+
+- Added back `Http\Discovery\NotFoundException` to preserve BC with 0.8 version
+
 ### Changed
 
 - Puli strategy renamed to Puli Beta strategy to prevent incompatibility with a future Puli stable
 
+### Deprecated
+
+- For BC reasons, the old `Http\Discovery\NotFoundException` (extending the new exception) will be thrown until version 2.0
+
 
 ## 0.9.1 - 2016-06-28
 

spec/ClassDiscoverySpec.php

@@ -4,7 +4,6 @@
 
 use Http\Discovery\ClassDiscovery;
 use Http\Discovery\Exception\DiscoveryFailedException;
-use Http\Discovery\Exception\NotFoundException;
 use Http\Discovery\Strategy\DiscoveryStrategy;
 use Puli\Discovery\Binding\ClassBinding;
 use Puli\GeneratedPuliFactory;

spec/HttpAsyncClientDiscoverySpec.php

@@ -4,7 +4,7 @@
 
 use Http\Client\HttpAsyncClient;
 use Http\Discovery\ClassDiscovery;
-use Http\Discovery\Exception\NotFoundException;
+use Http\Discovery\NotFoundException;
 use Http\Discovery\Strategy\DiscoveryStrategy;
 use Prophecy\Argument;
 use Puli\GeneratedPuliFactory;

spec/HttpClientDiscoverySpec.php

@@ -4,7 +4,7 @@
 
 use Http\Client\HttpClient;
 use Http\Discovery\ClassDiscovery;
-use Http\Discovery\Exception\NotFoundException;
+use Http\Discovery\NotFoundException;
 use Http\Discovery\Strategy\DiscoveryStrategy;
 use Puli\GeneratedPuliFactory;
 use Puli\Discovery\Api\Discovery;

spec/MessageFactoryDiscoverySpec.php

@@ -3,7 +3,7 @@
 namespace spec\Http\Discovery;
 
 use Http\Discovery\ClassDiscovery;
-use Http\Discovery\Exception\NotFoundException;
+use Http\Discovery\NotFoundException;
 use Http\Discovery\Strategy\DiscoveryStrategy;
 use Http\Message\MessageFactory;
 use Puli\GeneratedPuliFactory;

spec/StreamFactoryDiscoverySpec.php

@@ -3,7 +3,7 @@
 namespace spec\Http\Discovery;
 
 use Http\Discovery\ClassDiscovery;
-use Http\Discovery\Exception\NotFoundException;
+use Http\Discovery\NotFoundException;
 use Http\Discovery\Strategy\DiscoveryStrategy;
 use Http\Message\StreamFactory;
 use Puli\GeneratedPuliFactory;

spec/UriFactoryDiscoverySpec.php

@@ -3,7 +3,7 @@
 namespace spec\Http\Discovery;
 
 use Http\Discovery\ClassDiscovery;
-use Http\Discovery\Exception\NotFoundException;
+use Http\Discovery\NotFoundException;
 use Http\Discovery\Strategy\DiscoveryStrategy;
 use Http\Message\UriFactory;
 use Puli\GeneratedPuliFactory;

src/Exception/NotFoundException.php

@@ -5,8 +5,10 @@
 /**
  * Thrown when a discovery does not find any matches.
  *
+ * @final do NOT extend this class, not final for BC reasons
+ *
  * @author Márk Sági-Kazár <[email protected]>
  */
-final class NotFoundException extends \RuntimeException
+/*final */class NotFoundException extends \RuntimeException
 {
 }

src/HttpAsyncClientDiscovery.php

@@ -4,7 +4,6 @@
 
 use Http\Client\HttpAsyncClient;
 use Http\Discovery\Exception\DiscoveryFailedException;
-use Http\Discovery\Exception\NotFoundException;
 
 /**
  * Finds an HTTP Asynchronous Client.
@@ -18,7 +17,7 @@ final class HttpAsyncClientDiscovery extends ClassDiscovery
      *
      * @return HttpAsyncClient
      *
-     * @throws NotFoundException
+     * @throws Exception\NotFoundException
      */
     public static function find()
     {

src/HttpClientDiscovery.php

@@ -4,7 +4,6 @@
 
 use Http\Client\HttpClient;
 use Http\Discovery\Exception\DiscoveryFailedException;
-use Http\Discovery\Exception\NotFoundException;
 
 /**
  * Finds an HTTP Client.
@@ -18,7 +17,7 @@ final class HttpClientDiscovery extends ClassDiscovery
      *
      * @return HttpClient
      *
-     * @throws NotFoundException
+     * @throws Exception\NotFoundException
      */
     public static function find()
     {

src/MessageFactoryDiscovery.php

@@ -3,7 +3,6 @@
 namespace Http\Discovery;
 
 use Http\Discovery\Exception\DiscoveryFailedException;
-use Http\Discovery\Exception\NotFoundException;
 use Http\Message\MessageFactory;
 
 /**
@@ -18,7 +17,7 @@ final class MessageFactoryDiscovery extends ClassDiscovery
      *
      * @return MessageFactory
      *
-     * @throws NotFoundException
+     * @throws Exception\NotFoundException
      */
     public static function find()
     {

src/NotFoundException.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace Http\Discovery;
+
+/**
+ * Thrown when a discovery does not find any matches.
+ *
+ * @author Márk Sági-Kazár <[email protected]>
+ *
+ * @deprecated since since version 1.0, and will be removed in 2.0. Use {@link \Http\Discovery\Exception\NotFoundException} instead.
+ */
+final class NotFoundException extends \Http\Discovery\Exception\NotFoundException
+{
+}

src/StreamFactoryDiscovery.php

@@ -3,7 +3,6 @@
 namespace Http\Discovery;
 
 use Http\Discovery\Exception\DiscoveryFailedException;
-use Http\Discovery\Exception\NotFoundException;
 use Http\Message\StreamFactory;
 
 /**
@@ -18,7 +17,7 @@ final class StreamFactoryDiscovery extends ClassDiscovery
      *
      * @return StreamFactory
      *
-     * @throws NotFoundException
+     * @throws Exception\NotFoundException
      */
     public static function find()
     {

src/UriFactoryDiscovery.php

@@ -3,7 +3,6 @@
 namespace Http\Discovery;
 
 use Http\Discovery\Exception\DiscoveryFailedException;
-use Http\Discovery\Exception\NotFoundException;
 use Http\Message\UriFactory;
 
 /**
@@ -18,7 +17,7 @@ final class UriFactoryDiscovery extends ClassDiscovery
      *
      * @return UriFactory
      *
-     * @throws NotFoundException
+     * @throws Exception\NotFoundException
      */
     public static function find()
     {