Skip to content

Update README example to work in ZSH #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2023
Merged

Update README example to work in ZSH #243

merged 1 commit into from
May 18, 2023

Conversation

donatj
Copy link
Contributor

@donatj donatj commented May 17, 2023 •
edited
Loading

Q A
Bug fix? yes?
New feature? no
BC breaks? no
Deprecations? no
Related tickets no
Documentation yes
License MIT

What's in this PR?

Just quotes the example in the README

Why?

zsh and likely some other shells try to glob the * and cause the lines to fail.

image

zsh being the default shell on macOS now, seems like it should get fixed.

I quoted the first option for visual symmetry but it doesn't really require it.

Example Usage

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

To Do

dbu
dbu approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dbu dbu merged commit 8e2b023 into php-http:1.x May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donatj @dbu