Extract message factory #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the lowest version build looks weird. can the guzzle adapter really not support php 5.4? should we just move to 5.5? what feature only available in php 5.5 do we need? |
|
Yeah, I realized. Guzzle 6 only supports PHP 5.5 unfortunately. I think it would be okay to move the tests to 5.5. This was the reason for the ugly interface hack. Optionally we could require guzzle 5 instead, but as guzzle 6 is our main implementation, that's not so good IMO. |
|
well, testing lowest version with guzzle 5 would be interesting to see
if other versions work as well. otherwise we only know about guzzle 6.
ah, but the guzzle 5 adapter is not even done, so maybe lets just leave it.
|
sagikazarmark
force-pushed
the
extract_message_factory
branch
from
7f3b90f to
961abf5
Compare
Remove factories from discovery Add better warning for missing factories Fix tests Applied fixes from StyleCI
sagikazarmark
force-pushed
the
extract_message_factory
branch
from
ef74f6c to
bbfe827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.