Skip to content

Improve package #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
spec/ export-ignore
tests/ export-ignore
.editorconfig export-ignore
.gitattributes export-ignore
.gitignore export-ignore
.php_cs export-ignore
.scrutinizer.yml export-ignore
.styleci.yml export-ignore
.travis.yml export-ignore
CONTRIBUTING export-ignore
phpspec.ci.yml export-ignore
phpspec.yml.dist export-ignore
phpunit.xml.dist export-ignore
.editorconfig export-ignore
.gitattributes export-ignore
/.github/ export-ignore
.gitignore export-ignore
/.php_cs export-ignore
/.scrutinizer.yml export-ignore
/.styleci.yml export-ignore
/.travis.yml export-ignore
/behat.yml.dist export-ignore
/features/ export-ignore
/phpspec.ci.yml export-ignore
/phpspec.yml.dist export-ignore
/phpunit.xml.dist export-ignore
/spec/ export-ignore
/tests/ export-ignore
3 changes: 3 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Contributing

Please see our [contributing guide](http://docs.php-http.org/en/latest/development/contributing.html).
27 changes: 27 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
| Q | A
| ------------ | ---
| Bug? | no|yes
| New Feature? | no|yes
| Version | Specific version or SHA of a commit


#### Actual Behavior

What is the actual behavior?


#### Expected Behavior

What is the behavior you expect?


#### Steps to Reproduce

What are the steps to reproduce this bug? Please add code examples,
screenshots or links to GitHub repositories that reproduce the problem.


#### Possible Solutions

If you have already ideas how to solve the issue, add them here.
(remove this section if not needed)
43 changes: 43 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
| Q | A
| --------------- | ---
| Bug fix? | no|yes
| New feature? | no|yes
| BC breaks? | no|yes
| Deprecations? | no|yes
| Related tickets | fixes #X, partially #Y, mentioned in #Z
| Documentation | if this is a new feature, link to pull request in https://github.com/php-http/documentation that adds relevant documentation
| License | MIT


#### What's in this PR?

Explain what the changes in this PR do.


#### Why?

Which problem does the PR fix? (remove this section if you linked an issue above)


#### Example Usage

``` php
// If you added new features, show examples of how to use them here
// (remove this section if not a new feature)

$foo = new Foo();

// Now we can do
$foo->doSomething();
```


#### Checklist

- [ ] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
- [ ] Documentation pull request created (if not simply a bugfix)


#### To Do

- [ ] If the PR is not complete but you want to discuss the approach, list what remains to be done here
17 changes: 8 additions & 9 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
.puli/
bin/*
!bin/puli.phar
build/
vendor/
composer.lock
phpspec.yml
phpunit.xml
puli.json
/.puli/
/behat.yml
/build/
/composer.lock
/phpspec.yml
/phpunit.xml
/puli.json
/vendor/
4 changes: 4 additions & 0 deletions .styleci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ finder:
- "spec"
path:
- "src"
- "tests"

enabled:
- short_array_syntax

disabled:
- phpdoc_annotation_without_dot # This is still buggy: https://github.com/symfony/symfony/pull/19198
11 changes: 6 additions & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ sudo: false

cache:
directories:
- $HOME/.composer/cache
- $HOME/.composer/cache/files

php:
- 5.5
Expand All @@ -29,14 +29,15 @@ matrix:
env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" COVERAGE=true TEST_COMMAND="composer test-ci"

before_install:
- travis_retry composer self-update
- if [[ $COVERAGE != true && $TRAVIS_PHP_VERSION != hhvm ]]; then phpenv config-rm xdebug.ini; fi

install:
- travis_retry composer update ${COMPOSER_FLAGS} --prefer-source --no-interaction
- wget https://github.com/puli/cli/releases/download/1.0.0-beta10/puli.phar && chmod +x puli.phar
- travis_retry composer update ${COMPOSER_FLAGS} --prefer-dist --no-interaction

script:
- $TEST_COMMAND

after_success:
- if [[ "$COVERAGE" = true ]]; then wget https://scrutinizer-ci.com/ocular.phar; fi
- if [[ "$COVERAGE" = true ]]; then php ocular.phar code-coverage:upload --format=php-clover build/coverage.xml; fi
- if [[ $COVERAGE = true ]]; then wget https://scrutinizer-ci.com/ocular.phar; fi
- if [[ $COVERAGE = true ]]; then php ocular.phar code-coverage:upload --format=php-clover build/coverage.xml; fi
1 change: 0 additions & 1 deletion CONTRIBUTING

This file was deleted.

Binary file removed bin/puli.phar
Binary file not shown.
16 changes: 5 additions & 11 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
}
],
"require": {
"php": "^5.5|^7.0"
"php": "^5.5 || ^7.0"
},
"require-dev": {
"php-http/httplug": "^1.0",
"php-http/message-factory": "^1.0",
"puli/composer-plugin": "1.0.0-beta9",
"puli/composer-plugin": "1.0.0-beta9 || 1.0.0-beta10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is dev dependency anyways, do we need to allow multiple versions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i merged anyways, as this is really not important. if you want to change it, plesae do. otherwise i think it does no harm.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Should we add conflict field saying these are the only supported versions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think so. It is in the docs. (My BC pr)

If we want to do this properly we should config Travis to run tests with different versions of puli.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could mention it in the suggest section. i would not add conflicts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"phpspec/phpspec": "^2.4",
"henrikbjorn/phpspec-code-coverage" : "^1.0"
"henrikbjorn/phpspec-code-coverage" : "^2.0.2"
},
"suggest": {
"puli/composer-plugin": "Sets up Puli which is recommended for Discovery to work. Check http://docs.php-http.org/en/latest/discovery.html for more details.",
Expand All @@ -35,20 +35,14 @@
}
},
"scripts": {
"test": "bin/phpspec run",
"test-ci": "bin/phpspec run -c phpspec.ci.yml"
"test": "vendor/bin/phpspec run",
"test-ci": "vendor/bin/phpspec run -c phpspec.ci.yml"
},
"bin": [
"bin/puli.phar"
],
"extra": {
"branch-alias": {
"dev-master": "0.10-dev"
}
},
"config": {
"bin-dir": "bin"
},
"prefer-stable": true,
"minimum-stability": "beta"
}
3 changes: 2 additions & 1 deletion phpspec.ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ suites:
discovery_suite:
namespace: Http\Discovery
psr4_prefix: Http\Discovery
formatter.name: pretty
bootstrap: spec/autoload.php
extensions:
- PhpSpec\Extension\CodeCoverageExtension
code_coverage:
format: clover
output: build/coverage.xml
bootstrap: spec/autoload.php