-
Notifications
You must be signed in to change notification settings - Fork 46
Improve package #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve package #76
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,15 @@ | ||
spec/ export-ignore | ||
tests/ export-ignore | ||
.editorconfig export-ignore | ||
.gitattributes export-ignore | ||
.gitignore export-ignore | ||
.php_cs export-ignore | ||
.scrutinizer.yml export-ignore | ||
.styleci.yml export-ignore | ||
.travis.yml export-ignore | ||
CONTRIBUTING export-ignore | ||
phpspec.ci.yml export-ignore | ||
phpspec.yml.dist export-ignore | ||
phpunit.xml.dist export-ignore | ||
.editorconfig export-ignore | ||
.gitattributes export-ignore | ||
/.github/ export-ignore | ||
.gitignore export-ignore | ||
/.php_cs export-ignore | ||
/.scrutinizer.yml export-ignore | ||
/.styleci.yml export-ignore | ||
/.travis.yml export-ignore | ||
/behat.yml.dist export-ignore | ||
/features/ export-ignore | ||
/phpspec.ci.yml export-ignore | ||
/phpspec.yml.dist export-ignore | ||
/phpunit.xml.dist export-ignore | ||
/spec/ export-ignore | ||
/tests/ export-ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Contributing | ||
|
||
Please see our [contributing guide](http://docs.php-http.org/en/latest/development/contributing.html). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
| Q | A | ||
| ------------ | --- | ||
| Bug? | no|yes | ||
| New Feature? | no|yes | ||
| Version | Specific version or SHA of a commit | ||
|
||
|
||
#### Actual Behavior | ||
|
||
What is the actual behavior? | ||
|
||
|
||
#### Expected Behavior | ||
|
||
What is the behavior you expect? | ||
|
||
|
||
#### Steps to Reproduce | ||
|
||
What are the steps to reproduce this bug? Please add code examples, | ||
screenshots or links to GitHub repositories that reproduce the problem. | ||
|
||
|
||
#### Possible Solutions | ||
|
||
If you have already ideas how to solve the issue, add them here. | ||
(remove this section if not needed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
| Q | A | ||
| --------------- | --- | ||
| Bug fix? | no|yes | ||
| New feature? | no|yes | ||
| BC breaks? | no|yes | ||
| Deprecations? | no|yes | ||
| Related tickets | fixes #X, partially #Y, mentioned in #Z | ||
| Documentation | if this is a new feature, link to pull request in https://github.com/php-http/documentation that adds relevant documentation | ||
| License | MIT | ||
|
||
|
||
#### What's in this PR? | ||
|
||
Explain what the changes in this PR do. | ||
|
||
|
||
#### Why? | ||
|
||
Which problem does the PR fix? (remove this section if you linked an issue above) | ||
|
||
|
||
#### Example Usage | ||
|
||
``` php | ||
// If you added new features, show examples of how to use them here | ||
// (remove this section if not a new feature) | ||
|
||
$foo = new Foo(); | ||
|
||
// Now we can do | ||
$foo->doSomething(); | ||
``` | ||
|
||
|
||
#### Checklist | ||
|
||
- [ ] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix | ||
- [ ] Documentation pull request created (if not simply a bugfix) | ||
|
||
|
||
#### To Do | ||
|
||
- [ ] If the PR is not complete but you want to discuss the approach, list what remains to be done here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,8 @@ | ||
.puli/ | ||
bin/* | ||
!bin/puli.phar | ||
build/ | ||
vendor/ | ||
composer.lock | ||
phpspec.yml | ||
phpunit.xml | ||
puli.json | ||
/.puli/ | ||
/behat.yml | ||
/build/ | ||
/composer.lock | ||
/phpspec.yml | ||
/phpunit.xml | ||
/puli.json | ||
/vendor/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is dev dependency anyways, do we need to allow multiple versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i merged anyways, as this is really not important. if you want to change it, plesae do. otherwise i think it does no harm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. Should we add conflict field saying these are the only supported versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think so. It is in the docs. (My BC pr)
If we want to do this properly we should config Travis to run tests with different versions of puli.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could mention it in the suggest section. i would not add conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.