Skip to content

Using 'self' instead of 'static' #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2016
Merged

Using 'self' instead of 'static' #85

merged 2 commits into from
Nov 25, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Nov 25, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
Documentation n/a
License MIT

Why

Scrutinizer suggest to change self to static. Since the CommonClassesStrategy is make no sense to have static.

@dbu dbu merged commit cc792c2 into master Nov 25, 2016
@dbu dbu deleted the scrutinizer-fix branch November 25, 2016 10:05
@Nyholm
Copy link
Member Author

Nyholm commented Nov 25, 2016

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyholm @dbu @sagikazarmark