Skip to content

Added the two most common errors with discovery #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Mar 21, 2016

This will fix #98

I added this section for two reasons:

  • It can now be found when someone googles the exact error message.
  • The link to this section could be added in the Exception messages.

Common Errors
-------------

Error: "Puli Factory is not available"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need "Error:" part? And the quotes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we do not. I've updated the PR.

sagikazarmark added a commit that referenced this pull request Mar 22, 2016
Added the two most common errors with discovery
@sagikazarmark sagikazarmark merged commit 92cd365 into php-http:master Mar 22, 2016
@sagikazarmark
Copy link
Member

Thanks

@Nyholm
Copy link
Member Author

Nyholm commented Mar 22, 2016

Thank you for merging

@Nyholm Nyholm deleted the errors branch March 22, 2016 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain auto discovery for normal users
2 participants