Skip to content

Better table of clients/adapters #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 9, 2017
Merged

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 9, 2017

screen shot 2017-07-09 at 11 08 34

clients.rst Outdated

Client adapters:
"``clients/curl-client``", "Client", ":doc:`Docs </clients/curl-client>`, `Repo <https://github.com/php-http/curl-client>`__", "|curl_version| |curl_downloads| "
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im using inline anonymous links to avoid:

WARNING: Duplicate explicit target name: "repo"

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@Nyholm
Copy link
Member Author

Nyholm commented Jul 9, 2017

Im trying to get the build to pass. I do not agree the errors:

/doc/clients/guzzle5-adapter.rst:: WARNING: document isn't included in any toctree

It is in the left sidebar..

Any idea how I could make it work?

@Nyholm
Copy link
Member Author

Nyholm commented Jul 9, 2017

The clients are not in sidebar anymore... Is that okey? If not, how can I get them back?

@Nyholm
Copy link
Member Author

Nyholm commented Jul 9, 2017

hm. Position of :toctree: in the docs do matter. Im done with this PR now. Only change is as you see on the sceenshot

@Nyholm Nyholm merged commit 1f2b570 into php-http:master Jul 9, 2017
@Nyholm
Copy link
Member Author

Nyholm commented Jul 9, 2017

Thank you for the reviews

@Nyholm Nyholm deleted the patch-clients branch July 9, 2017 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants