phpstan cleanup

Author: dbu

.github/workflows/static.yml

@@ -33,4 +33,4 @@ jobs:
       - name: PHP-CS-Fixer
         uses: docker://oskarstark/php-cs-fixer-ga
         with:
-          args: --dry-run --diff-format udiff
+          args: --dry-run --diff

phpstan-baseline.neon

@@ -80,11 +80,6 @@ parameters:
 			count: 1
 			path: src/CookieJar.php
 
-		-
-			message: "#^Method Http\\\\Message\\\\CookieJar\\:\\:findMatchingCookies\\(\\) should return array\\<Http\\\\Message\\\\Cookie\\> but returns array\\<int, object\\>\\.$#"
-			count: 1
-			path: src/CookieJar.php
-
 		-
 			message: "#^Method Http\\\\Message\\\\CookieJar\\:\\:setCookies\\(\\) has no return type specified\\.$#"
 			count: 1
@@ -115,11 +110,6 @@ parameters:
 			count: 1
 			path: src/CookieJar.php
 
-		-
-			message: "#^Method Http\\\\Message\\\\CookieJar\\:\\:getIterator\\(\\) return type has no value type specified in iterable type Traversable\\<mixed, mixed\\>\\.$#"
-			count: 1
-			path: src/CookieJar.php
-
 		-
 			message: "#^Property Http\\\\Message\\\\CookieUtil\\:\\:\\$dateFormats type has no value type specified in iterable type array\\.$#"
 			count: 1
@@ -130,11 +120,6 @@ parameters:
 			count: 1
 			path: src/Encoding/ChunkStream.php
 
-		-
-			message: "#^Access to an undefined property object\\:\\:\\$datalen\\.$#"
-			count: 2
-			path: src/Encoding/Filter/Chunk.php
-
 		-
 			message: "#^Method Http\\\\Message\\\\Encoding\\\\FilteredStream\\:\\:fill\\(\\) has no return type specified\\.$#"
 			count: 1
@@ -264,3 +249,8 @@ parameters:
 			message: "#^Unreachable statement \\- code above always terminates\\.$#"
 			count: 1
 			path: src/UriFactory/SlimUriFactory.php
+
+		-
+			message: "#^Call to function array_key_exists\\(\\) with 'chunk' and array<int, string> will always evaluate to false\\.$#"
+			count: 1
+			path: src/filters.php

phpstan.neon.dist

@@ -5,3 +5,8 @@ parameters:
     level: max
     paths:
         - src
+    excludePaths:
+        analyse:
+            - %currentWorkingDirectory%/src/MessageFactory/*
+            - %currentWorkingDirectory%/src/StreamFactory/*
+            - %currentWorkingDirectory%/src/UriFactory/*

src/CookieJar.php

@@ -10,7 +10,7 @@
 final class CookieJar implements \Countable, \IteratorAggregate
 {
     /**
-     * @var \SplObjectStorage<object, mixed>
+     * @var \SplObjectStorage<Cookie, mixed>
      */
     private $cookies;