Skip to content

Allow us to reset the builder #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2016
Merged

Allow us to reset the builder #25

merged 1 commit into from
Dec 30, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 25, 2016

No description provided.

This was referenced Dec 25, 2016
Closed
Merged
@sagikazarmark sagikazarmark requested a review from dbu December 28, 2016 19:05
dbu
dbu approved these changes Dec 30, 2016
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the implementation seems sane to me. i would think people should usually just create a new builder for a new stream, but if we want full DI then better this than a MultipartStreamBuilderFactory (then the 90ies would call and want their Java back)

@Nyholm
Copy link
Member Author

Nyholm commented Dec 30, 2016

If someone adds a custom mime type helper I can't create a new MultipartStreamBuilder... I know I changed my mind about this but this seams to be the reasonable way to go.

@dbu dbu merged commit 5e02c79 into master Dec 30, 2016
@dbu dbu deleted the issue-24 branch December 30, 2016 23:19
@dbu
Copy link
Contributor

dbu commented Dec 30, 2016

thanks

@Nyholm
Copy link
Member Author

Nyholm commented Dec 30, 2016

Thank you for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @dbu