fix: ensure invalid arguments not caught by implementation are flagged

Adds a `fail()` call when an invalid argument is not caught.

Author: weierophinney

src/MessageTrait.php

@@ -3,6 +3,7 @@
 namespace Http\Psr7Test;
 
 use InvalidArgumentException;
+use PHPUnit\Framework\AssertionFailedError;
 use Psr\Http\Message\MessageInterface;
 use Throwable;
 use TypeError;
@@ -143,6 +144,10 @@ public function testWithHeaderInvalidArguments($name, $value)
         try {
             $initialMessage = $this->getMessage();
             $initialMessage->withHeader($name, $value);
+            $this->fail('withHeader() should have raised exception on invalid argument');
+        } catch (AssertionFailedError $e) {
+            // invalid argument not caught
+            throw $e;
         } catch (TypeError|InvalidArgumentException $e) {
             // valid
             $this->assertTrue($e instanceof Throwable);
@@ -192,6 +197,10 @@ public function testWithAddedHeaderInvalidArguments($name, $value)
         try {
             $initialMessage = $this->getMessage();
             $initialMessage->withAddedHeader($name, $value);
+            $this->fail('withAddedHeader() should have raised exception on invalid argument');
+        } catch (AssertionFailedError $e) {
+            // invalid argument not caught
+            throw $e;
         } catch (TypeError|InvalidArgumentException $e) {
             // valid
             $this->assertTrue($e instanceof Throwable);

src/RequestIntegrationTest.php

@@ -3,6 +3,7 @@
 namespace Http\Psr7Test;
 
 use InvalidArgumentException;
+use PHPUnit\Framework\AssertionFailedError;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\UriInterface;
 use Throwable;
@@ -101,6 +102,10 @@ public function testMethodWithInvalidArguments($method)
 
         try {
             $this->request->withMethod($method);
+            $this->fail('withMethod() should have raised exception on invalid argument');
+        } catch (AssertionFailedError $e) {
+            // invalid argument not caught
+            throw $e;
         } catch (InvalidArgumentException|TypeError $e) {
             // valid
             $this->assertTrue($e instanceof Throwable);

src/ResponseIntegrationTest.php

@@ -3,6 +3,7 @@
 namespace Http\Psr7Test;
 
 use InvalidArgumentException;
+use PHPUnit\Framework\AssertionFailedError;
 use Psr\Http\Message\ResponseInterface;
 use Throwable;
 use TypeError;
@@ -63,6 +64,10 @@ public function testStatusCodeInvalidArgument($statusCode)
 
         try {
             $this->response->withStatus($statusCode);
+            $this->fail('withStatus() should have raised exception on invalid argument');
+        } catch (AssertionFailedError $e) {
+            // invalid argument not caught
+            throw $e;
         } catch (InvalidArgumentException|TypeError $e) {
             // valid
             $this->assertTrue($e instanceof Throwable);

src/UriIntegrationTest.php

@@ -3,6 +3,7 @@
 namespace Http\Psr7Test;
 
 use InvalidArgumentException;
+use PHPUnit\Framework\AssertionFailedError;
 use Psr\Http\Message\UriInterface;
 use Throwable;
 use TypeError;
@@ -52,6 +53,10 @@ public function testWithSchemeInvalidArguments($schema)
 
         try {
             $this->createUri('/')->withScheme($schema);
+            $this->fail('withScheme() should have raised exception on invalid argument');
+        } catch (AssertionFailedError $e) {
+            // invalid argument not caught
+            throw $e;
         } catch (InvalidArgumentException|TypeError $e) {
             // valid
             $this->assertTrue($e instanceof Throwable);