Skip to content

Commit 2b32140

Browse files
committed
minor fix for version handler
1 parent 09d0f27 commit 2b32140

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

php_memcached_server.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -560,6 +560,7 @@ protocol_binary_response_status s_version_handler (const void *cookie,
560560
MEMC_MAKE_ZVAL_COOKIE(zcookie, cookie);
561561

562562
ZVAL_NULL(&zversion);
563+
ZVAL_MAKE_REF(&zversion);
563564

564565
ZVAL_COPY(&params[0], &zcookie);
565566
ZVAL_COPY(&params[1], &zversion);

tests/memcachedserver.phpt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ var_dump($cache->get('get_this'));
3131
$cache->set ('set_key', 'value 1', 100);
3232
$cache->replace ('replace_key', 'value 2', 200);
3333

34-
var_dump($cache->getStats());
34+
// TODO var_dump($cache->getVersion());
35+
// TODO var_dump($cache->getStats());
3536

3637
$cache->quit();
3738

@@ -54,5 +55,5 @@ client_id=[%s]: Noop
5455
string(20) "Hello to you client!"
5556
client_id=[%s]: Set key=[set_key], value=[value 1], flags=[0], expiration=[100], cas=[0]
5657
client_id=[%s]: Replace key=[replace_key], value=[value 2], flags=[0], expiration=[200], cas=[0]
57-
bool(false)
58+
client_id=[%s]: Client quit
5859
Done

tests/server.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,13 @@ function ($client_id, $key, $value, $flags, $expiration, $cas, &$result_cas) {
7979
$server->on (Memcached::ON_STAT,
8080
function ($client_id, $key, &$value) {
8181
echo "client_id=[$client_id]: Stat key=[$key]" . PHP_EOL;
82+
$value = "Stat reply for $key";
83+
return Memcached::RESPONSE_SUCCESS;
84+
});
85+
86+
$server->on (Memcached::ON_VERSION,
87+
function ($client_id, &$value) {
88+
echo "client_id=[$client_id]: Version" . PHP_EOL;
8289
$value = "Stat reply";
8390
return Memcached::RESPONSE_SUCCESS;
8491
});

0 commit comments

Comments
 (0)