Skip to content

Commit 470e909

Browse files
committed
Refactor adding submenu builder
1 parent 1701b32 commit 470e909

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/CliMenuBuilder.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -152,15 +152,16 @@ public function addAsciiArt(string $art, string $position = AsciiArtItem::POSITI
152152
*/
153153
public function addSubMenu(string $id, CliMenuBuilder $subMenuBuilder = null) : CliMenuBuilder
154154
{
155-
$this->menuItems[] = $id;
156-
if (!empty($subMenuBuilder)) {
157-
$subMenuBuilder->setParent($this);
158-
$this->subMenuBuilders[$id] = $subMenuBuilder;
159-
return $this;
160-
} else {
155+
$this->menuItems[] = $id;
156+
157+
if (null === $subMenuBuilder) {
161158
$this->subMenuBuilders[$id] = new static($this);
162159
return $this->subMenuBuilders[$id];
160+
163161
}
162+
163+
$this->subMenuBuilders[$id] = $subMenuBuilder;
164+
return $this;
164165
}
165166

166167
/**

0 commit comments

Comments
 (0)