Skip to content

Commit c5adfa1

Browse files
committed
Fix bug with extra rendering
1 parent cea7011 commit c5adfa1

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/MenuItem/SelectableItemRenderer.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ public function render(MenuStyle $menuStyle, MenuItemInterface $item, bool $sele
2020

2121
return mapWithKeys(
2222
$this->wrapAndIndentText($marker, $item->getText(), $availableTextWidth),
23-
function (int $key, string $row) use ($menuStyle, $itemStyle, $availableTextWidth, $disabled) {
23+
function (int $key, string $row) use ($menuStyle, $item, $availableTextWidth, $disabled) {
2424
$text = $disabled ? $menuStyle->getDisabledItemText($row) : $row;
2525

26-
return $key === 0 && $itemStyle->getDisplaysExtra()
27-
? $this->lineWithExtra($text, $availableTextWidth, $itemStyle)
26+
return $key === 0 && $item->showsItemExtra()
27+
? $this->lineWithExtra($text, $availableTextWidth, $item->getStyle())
2828
: $text;
2929
}
3030
);

test/MenuItem/SelectableItemRendererTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ public function testRender() : void
2525
$item = new SelectableItem('SOME TEXT', function () {
2626
});
2727
$item->setStyle($style);
28+
$item->showItemExtra();
2829

2930
self::assertEquals(
3031
[
@@ -44,6 +45,7 @@ public function testRenderMultiLine() : void
4445
$item = new SelectableItem('SOME TEXT THAT IS MUCH LONGER THAN THE AVAILABLE WIDTH', function () {
4546
});
4647
$item->setStyle($style);
48+
$item->showItemExtra();
4749

4850
self::assertEquals(
4951
[
@@ -65,6 +67,7 @@ public function testRenderUnselected() : void
6567
$item = new SelectableItem('SOME TEXT', function () {
6668
});
6769
$item->setStyle($style);
70+
$item->showItemExtra();
6871

6972
self::assertEquals(
7073
[
@@ -84,6 +87,7 @@ public function testRenderDisabled() : void
8487
$item = new SelectableItem('SOME TEXT', function () {
8588
});
8689
$item->setStyle($style);
90+
$item->showItemExtra();
8791

8892
self::assertEquals(
8993
[

0 commit comments

Comments
 (0)