Make example code consistent with imports and tags #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=========================================
Coverage 96.79% 96.79%
Complexity 428 428
=========================================
Files 27 27
Lines 1312 1312
=========================================
Hits 1270 1270
Misses 42 42Continue to review full report at Codecov.
|
Lynesth
approved these changes
May 14, 2018
README.md
Outdated
| use PhpSchool\CliMenu\CliMenuBuilder; | ||
| <?php | ||
|
|
||
| use PhpSchool\CliMenu\Builder\CliMenuBuilder; | ||
| use PhpSchool\CliMenu\Action\ExitAction; | ||
| use \PhpSchool\CliMenu\Action\GoBackAction; |
There was a problem hiding this comment.
Shouldn't we use the leading slash everytime ?
I guess it doesn't matter much for docs examples, then just remove it here for consistency.
There was a problem hiding this comment.
Actually its recommended against in the PHP docs, will remove.
AydinHassan
force-pushed
the
doc-consistency
branch
from
8d0ad56 to
0d6cfc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57.
Needs to be merged after #133 otherwise namespaces are wrong.