Skip to content

Simplify builder code #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2018
Merged

Simplify builder code #149

merged 2 commits into from
May 15, 2018

Conversation

AydinHassan
Copy link
Member

No description provided.

@AydinHassan AydinHassan requested a review from Lynesth May 15, 2018 10:35
@codecov-io
Copy link

codecov-io commented May 15, 2018

Codecov Report

Merging #149 into master will increase coverage by 0.56%.
The diff coverage is 98%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #149      +/-   ##
============================================
+ Coverage     95.29%   95.85%   +0.56%     
+ Complexity      434      425       -9     
============================================
  Files            27       27              
  Lines          1338     1303      -35     
============================================
- Hits           1275     1249      -26     
+ Misses           63       54       -9
Impacted Files Coverage Δ Complexity Δ
src/Builder/SplitItemBuilder.php 0% <0%> (ø) 8 <1> (ø) ⬇️
src/Builder/BuilderUtils.php 94.87% <100%> (+20.51%) 10 <0> (ø) ⬇️
src/MenuStyle.php 96.99% <100%> (+0.17%) 70 <1> (ø) ⬇️
src/Builder/CliMenuBuilder.php 91.78% <100%> (-1.59%) 51 <3> (-9)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13311a1...00e4a9b. Read the comment docs.

Copy link
Collaborator

@Lynesth Lynesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@AydinHassan AydinHassan force-pushed the simplify-menu-style-builder branch from 8cf8d3a to 00e4a9b Compare May 15, 2018 12:53
@AydinHassan AydinHassan merged commit 9ac14b7 into master May 15, 2018
@AydinHassan AydinHassan deleted the simplify-menu-style-builder branch May 15, 2018 12:57
@AydinHassan AydinHassan added this to the 3.0 milestone May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants