Skip to content

Removes $callback->bindTo() #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Removes $callback->bindTo() #192

merged 1 commit into from
Dec 17, 2019

Conversation

jtreminio
Copy link
Contributor

Closes #191

@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #192 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #192      +/-   ##
============================================
- Coverage     93.19%   93.18%   -0.01%     
  Complexity      486      486              
============================================
  Files            27       27              
  Lines          1470     1468       -2     
============================================
- Hits           1370     1368       -2     
  Misses          100      100
Impacted Files Coverage Δ Complexity Δ
src/Builder/CliMenuBuilder.php 83.58% <ø> (-0.09%) 65 <0> (ø)
src/Builder/SplitItemBuilder.php 73.52% <ø> (-0.76%) 10 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4db90...240a745. Read the comment docs.

@AydinHassan
Copy link
Member

Let's go with this. Thanks @jtreminio .

@AydinHassan AydinHassan merged commit 4618e39 into php-school:master Dec 17, 2019
@jtreminio jtreminio mentioned this pull request Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't call $callback->bindTo()
3 participants