Skip to content

Checkbox + Radio item-level styling - CR Changes #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2019
Merged

Checkbox + Radio item-level styling - CR Changes #206

merged 1 commit into from
Dec 19, 2019

Conversation

jtreminio
Copy link
Contributor

@jtreminio jtreminio commented Dec 19, 2019

Related to #205

@jtreminio jtreminio changed the title CR changes Checkbox + Radio item-level styling - CR Changes Dec 19, 2019
@AydinHassan AydinHassan merged commit d3a76ba into php-school:item-style Dec 19, 2019
@codecov-io
Copy link

codecov-io commented Dec 19, 2019

Codecov Report

Merging #206 into item-style will decrease coverage by 1.25%.
The diff coverage is 78.47%.

Impacted file tree graph

@@               Coverage Diff                @@
##             item-style     #206      +/-   ##
================================================
- Coverage         93.99%   92.73%   -1.26%     
- Complexity          530      561      +31     
================================================
  Files                32       30       -2     
  Lines              1648     1693      +45     
================================================
+ Hits               1549     1570      +21     
- Misses               99      123      +24
Impacted Files Coverage Δ Complexity Δ
src/MenuItem/RadioItem.php 100% <100%> (ø) 21 <10> (+10) ⬆️
src/CliMenu.php 95.25% <100%> (ø) 113 <2> (ø) ⬇️
src/Builder/CliMenuBuilder.php 78.94% <46.15%> (-3.78%) 78 <6> (+8)
src/Builder/SplitItemBuilder.php 77.27% <72.22%> (-6.66%) 20 <6> (+6)
src/MenuItem/CheckboxItem.php 92.72% <80%> (-7.28%) 20 <10> (+10)
src/Style/CheckboxStyle.php 88.57% <85.71%> (-11.43%) 12 <11> (+9)
src/Style/RadioStyle.php 88.57% <85.71%> (-11.43%) 12 <11> (+9)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c48311...8179b35. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants