Skip to content

Tests for CheckboxStyle & RadioStyle #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Tests for CheckboxStyle & RadioStyle #213

merged 1 commit into from
Dec 20, 2019

Conversation

AydinHassan
Copy link
Member

I also refactored hasChangedFromDefaults. I prefer this way where we don't need an extra property and to litter each setter with a flag set.

@codecov-io
Copy link

codecov-io commented Dec 20, 2019

Codecov Report

Merging #213 into master will increase coverage by 0.47%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #213      +/-   ##
============================================
+ Coverage     93.04%   93.52%   +0.47%     
  Complexity      558      558              
============================================
  Files            30       30              
  Lines          1667     1667              
============================================
+ Hits           1551     1559       +8     
+ Misses          116      108       -8
Impacted Files Coverage Δ Complexity Δ
src/Style/RadioStyle.php 100% <100%> (+11.76%) 12 <0> (ø) ⬇️
src/Style/CheckboxStyle.php 100% <100%> (+11.76%) 12 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95df7b9...8e9c251. Read the comment docs.

@AydinHassan AydinHassan merged commit 91e2348 into master Dec 20, 2019
@AydinHassan AydinHassan deleted the style-tests branch December 20, 2019 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants