Skip to content

Custom item styles #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2020
Merged

Custom item styles #232

merged 4 commits into from
Feb 16, 2020

Conversation

AydinHassan
Copy link
Member

Allow to register custom items with styles, so that we can propagate styles for custom items.

@codecov-io
Copy link

Codecov Report

Merging #232 into master will decrease coverage by 0.1%.
The diff coverage is 90.47%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #232      +/-   ##
===========================================
- Coverage     92.61%   92.5%   -0.11%     
- Complexity      611     626      +15     
===========================================
  Files            36      37       +1     
  Lines          1827    1882      +55     
===========================================
+ Hits           1692    1741      +49     
- Misses          135     141       +6
Impacted Files Coverage Δ Complexity Δ
src/Util/Collection.php 100% <100%> (ø) 6 <6> (?)
src/Style/Exception/InvalidStyle.php 100% <100%> (ø) 4 <1> (+1) ⬆️
src/CliMenu.php 94.17% <100%> (+0.11%) 116 <1> (+1) ⬆️
src/MenuItem/SplitItem.php 98.64% <100%> (+0.03%) 46 <0> (ø) ⬇️
src/Style/Locator.php 100% <100%> (ø) 13 <3> (+3) ⬆️
src/Util/ArrayUtils.php 100% <100%> (ø) 0 <0> (ø) ⬇️
src/Builder/SplitItemBuilder.php 75% <62.5%> (-2.5%) 14 <2> (+2)
src/Builder/CliMenuBuilder.php 71.07% <75%> (+0.2%) 77 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db978a6...8cd1cab. Read the comment docs.

@AydinHassan AydinHassan merged commit 5362114 into master Feb 16, 2020
@AydinHassan AydinHassan deleted the custom-item-styles branch February 16, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants