Skip to content

Toggle extra #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 6, 2016
Merged

Toggle extra #46

merged 5 commits into from
Oct 6, 2016

Conversation

AydinHassan
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 5, 2016

Current coverage is 82.89% (diff: 85.00%)

Merging #46 into develop will increase coverage by 0.04%

@@            develop        #46   diff @@
==========================================
  Files            15         15          
  Lines           595        614    +19   
  Methods         156        166    +10   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            493        509    +16   
- Misses          102        105     +3   
  Partials          0          0          

Powered by Codecov. Last update 721717c...6120afd

@AydinHassan
Copy link
Member Author

@mikeymike this is ready for review now, this contains a BC break on the MenuItemInterface so we will have to tag 2.0.0 if we merge develop in to master, unless you can think of a better way of achieving this?

Copy link
Member

@mikeymike mikeymike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeymike mikeymike merged commit df89aac into develop Oct 6, 2016
@mikeymike mikeymike deleted the toggle-extra branch October 6, 2016 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants