Skip to content

Add emacs style up/down shortcuts ctrl+n and ctrl+p #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lachlankrautz
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 9, 2017

Codecov Report

Merging #67 into master will decrease coverage by 0.21%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #67      +/-   ##
============================================
- Coverage     88.76%   88.55%   -0.22%     
- Complexity      239      241       +2     
============================================
  Files            18       18              
  Lines           730      734       +4     
============================================
+ Hits            648      650       +2     
- Misses           82       84       +2
Impacted Files Coverage Δ Complexity Δ
src/Terminal/UnixTerminal.php 9.52% <0%> (-0.32%) 31 <0> (ø)
src/CliMenuBuilder.php 98.7% <0%> (ø) 45% <0%> (+1%) ⬆️
src/CliMenu.php 89.18% <0%> (+0.07%) 55% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870340f...1c50927. Read the comment docs.

@AydinHassan
Copy link
Member

@lachlankrautz am I missing something here? they just seem like empty strings in the GitHub diff?

@AydinHassan
Copy link
Member

Seems it's just GH. I pulled and it looks fine. Thanks!

@AydinHassan AydinHassan merged commit 539f817 into php-school:master Dec 11, 2017
@AydinHassan
Copy link
Member

I tagged 2.1.0 which your changes in :)

@lachlankrautz
Copy link
Contributor Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants