Skip to content

WIP: Inputs #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

WIP: Inputs #78

wants to merge 2 commits into from

Conversation

AydinHassan
Copy link
Member

No description provided.

@mfour-merickson
Copy link

@AydinHassan Is there a technical reason for having minimum PHP as 7.2, that is quite restricting and I am going to have to yank this out of my project (or continue using the current version I have installed)

@AydinHassan
Copy link
Member Author

Not really - it would probably be a new major version for these features anyway. To be honest I didn't even mean to push that commit - that was laying around from a while ago. I guess we could go down to 7.1 but it's definitely time for a bump.

@mikeerickson
Copy link

I think a jump to 7.1 would be acceptable, but 7.2 is drastic for us (then I would have to deploy our tool w/ a special docker container which contains 7.2

Our internal dev team is in process of moving from 7.0.23 -> 7.1 and that took and act of Congress :)

Please consider reducing requirement to 7.1

@AydinHassan
Copy link
Member Author

Bumped to 7.1 in #79. This will need rebasing off master when that is reviewed + merged.

@AydinHassan
Copy link
Member Author

closing in favour of #81

@AydinHassan AydinHassan deleted the inputs branch May 8, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AydinHassan @mfour-merickson @mikeerickson