Adds alternateText to AsciiArtItem #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AydinHassan
requested changes
May 2, 2018
| $asciiArtItem = new AsciiArtItem($art, $position); | ||
|
|
||
| if ($asciiArtItem->getArtLength() <= $this->getMenuStyle()->getContentWidth()) { | ||
| $this->addMenuItem($asciiArtItem); |
There was a problem hiding this comment.
Maybe it would be cleaner to just add a static item here instead? Then we wouldn't have to modify AsciiArtItem
There was a problem hiding this comment.
Then it wouldn't work if you first create the AsciiArtItem and then add it using addMenuItem().
Edit: That's why I went with this method.
There was a problem hiding this comment.
Ok makes sense - I begin to think that the CliMenuBuilder was not such a good idea.
AydinHassan
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will replace the AsciiArtItem with a StaticItem if the art is to big to fit in the menu/screen.
The new output will ignore position and be left aligned. Will print an empty line by default.