Avoid preg_match in Telegram::classNameToCommandName()

mlocati · mlocati · commit 63ba67dce931 · 2022-10-27T16:35:25.000+02:00
diff --git a/src/Telegram.php b/src/Telegram.php
@@ -1294,10 +1294,11 @@ public function getUpdateFilter(): ?callable
      */
     protected function classNameToCommandName(string $class): string
     {
-        if (!preg_match('/^(.+)Command$/', $class, $matches)) {
+        // 7 is the length of 'Command'
+        if (substr($class, -7) !== 'Command') {
             return '';
         }
-        $temp = $matches[1];
+        $temp = substr($class, 0, -7);
         $chunks = [];
         $currentUpperCaseLetter = '';
         while ($temp !== '') {

Original file line number	Diff line number	Diff line change
`@@ -1294,10 +1294,11 @@ public function getUpdateFilter(): ?callable`
`1294`	`1294`	`*/`
`1295`	`1295`	`protected function classNameToCommandName(string $class): string`
`1296`	`1296`	`{`
`1297`		`- if (!preg_match('/^(.+)Command$/', $class, $matches)) {`
	`1297`	`+ // 7 is the length of 'Command'`
	`1298`	`+ if (substr($class, -7) !== 'Command') {`
`1298`	`1299`	`return '';`
`1299`	`1300`	`}`
`1300`		`- $temp = $matches[1];`
	`1301`	`+ $temp = substr($class, 0, -7);`
`1301`	`1302`	`$chunks = [];`
`1302`	`1303`	`$currentUpperCaseLetter = '';`
`1303`	`1304`	`while ($temp !== '') {`