Merge pull request #1162 from noplanman/fix-download-upload-paths

Fix path assignment for download and upload paths

Author: noplanman

CHANGELOG.md

@@ -11,6 +11,7 @@ Exclamation symbols (:exclamation:) note something of importance e.g. breaking c
 ### Deprecated
 ### Removed
 ### Fixed
+- Ensure download and upload path variables are defined.
 ### Security
 
 ## [0.70.0] - 2020-12-21

src/Telegram.php

@@ -90,14 +90,14 @@ class Telegram
      *
      * @var string
      */
-    protected $upload_path;
+    protected $upload_path = '';
 
     /**
      * Download path
      *
      * @var string
      */
-    protected $download_path;
+    protected $download_path = '';
 
     /**
      * MySQL integration

tests/Unit/TelegramTest.php

@@ -18,11 +18,11 @@
 use Longman\TelegramBot\TelegramLog;
 
 /**
- * @package         TelegramTest
+ * @link            https://github.com/php-telegram-bot/core
  * @author          Avtandil Kikabidze <[email protected]>
  * @copyright       Avtandil Kikabidze <[email protected]>
  * @license         http://opensource.org/licenses/mit-license.php  The MIT License (MIT)
- * @link            https://github.com/php-telegram-bot/core
+ * @package         TelegramTest
  */
 class TelegramTest extends TestCase
 {
@@ -133,6 +133,18 @@ public function testAddCustomCommandsPaths(): void
         self::assertCount(4, $tg->getCommandsPaths());
     }
 
+    public function testSettingDownloadUploadPaths(): void
+    {
+        self::assertEmpty($this->telegram->getDownloadPath());
+        self::assertEmpty($this->telegram->getUploadPath());
+
+        $this->telegram->setDownloadPath('/down/below');
+        $this->telegram->setUploadPath('/up/above');
+
+        self::assertSame('/down/below', $this->telegram->getDownloadPath());
+        self::assertSame('/up/above', $this->telegram->getUploadPath());
+    }
+
     public function testGetCommandsList(): void
     {
         $commands = $this->telegram->getCommandsList();