Skip to content

Commit 025cb9f

Browse files
committed
Address review comments
1 parent 82d9498 commit 025cb9f

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

Zend/zend_exceptions.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -761,9 +761,7 @@ void zend_register_default_exception(void) /* {{{ */
761761
/* Declared manually because it uses constant E_ERROR. */
762762
zval severity_default_value;
763763
ZVAL_LONG(&severity_default_value, E_ERROR);
764-
zend_string *severity_name = zend_string_init("severity", sizeof("severity") - 1, 1);
765-
zend_declare_typed_property(zend_ce_error_exception, severity_name, &severity_default_value, ZEND_ACC_PROTECTED, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
766-
zend_string_release(severity_name);
764+
zend_declare_typed_property(zend_ce_error_exception, ZSTR_KNOWN(ZEND_STR_SEVERITY), &severity_default_value, ZEND_ACC_PROTECTED, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
767765

768766
zend_ce_error = register_class_Error(zend_ce_throwable);
769767
zend_ce_error->create_object = zend_default_exception_new;

Zend/zend_exceptions.stub.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ final public function getSeverity(): int {}
7575

7676
class Error implements Throwable
7777
{
78-
/** @var string */
78+
/** @var string Intentionally left untyped for BC reasons */
7979
protected $message = "";
8080
private string $string = "";
81-
/** @var int */
81+
/** @var int Intentionally left untyped for BC reasons */
8282
protected $code = 0;
8383
protected string $file = "";
8484
protected int $line;

Zend/zend_exceptions_arginfo.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* This is a generated file, edit the .stub.php file instead.
2-
* Stub hash: 5ba5b069f9f32e72d743a9565855cc09f408e164 */
2+
* Stub hash: c2cff7b74e950f7c402f9d0684ef5b15258e1fcf */
33

44
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_Throwable_getMessage, 0, 0, IS_STRING, 0)
55
ZEND_END_ARG_INFO()

0 commit comments

Comments
 (0)