Skip to content

Commit 059c9b5

Browse files
committed
Address code review comments
1 parent 5419493 commit 059c9b5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

ext/spl/spl_directory.stub.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public function getFilename() {}
1414
public function getExtension() {}
1515

1616
/** @return string */
17-
public function getBasename(string $suffix = UNKNOWN) {}
17+
public function getBasename(string $suffix = "") {}
1818

1919
/** @return string|false */
2020
public function getPathname() {}
@@ -71,7 +71,7 @@ public function getLinkTarget() {}
7171
public function getRealPath() {}
7272

7373
/** @return SplFileInfo */
74-
public function getFileInfo(string $class_name = SplFileInfo::class) {}
74+
public function getFileInfo(string $class_name = UNKNOWN) {}
7575

7676
/** @return SplFileInfo|null */
7777
public function getPathInfo(string $class_name = UNKNOWN) {}
@@ -104,7 +104,7 @@ public function getFilename() {}
104104
public function getExtension() {}
105105

106106
/** @return string */
107-
public function getBasename(string $suffix = UNKNOWN) {}
107+
public function getBasename(string $suffix = "") {}
108108

109109
/** @return bool */
110110
public function isDot() {}
@@ -132,7 +132,7 @@ public function __toString(): string {}
132132

133133
class FilesystemIterator extends DirectoryIterator
134134
{
135-
public function __construct(string $path, int $flags = FilesystemIterator::KEY_AS_PATHNAME | FilesystemIterator::URRENT_AS_FILEINFO | FilesystemIterator::SKIP_DOTS) {}
135+
public function __construct(string $path, int $flags = FilesystemIterator::KEY_AS_PATHNAME | FilesystemIterator::CURRENT_AS_FILEINFO | FilesystemIterator::SKIP_DOTS) {}
136136

137137
/** @return void */
138138
public function rewind() {}
@@ -204,7 +204,7 @@ public function fgetcsv(string $delimiter = ",", string $enclosure = '"', $escap
204204
/** @return int|false */
205205
public function fputcsv(array $fields, string $delimiter = ',', string $enclosure = '"', string $escape = "\\") {}
206206

207-
/** @return void */
207+
/** @return null|false */
208208
public function setCsvControl(string $delimiter = ",", string $enclosure = "\"", string $escape = "\\") {}
209209

210210
/** @return array */

0 commit comments

Comments
 (0)