Fix unstable get_iterator pointer in shm on Windows

Author: iluuu1994

Zend/zend_compile.c

@@ -8575,10 +8575,13 @@ static void zend_compile_property_hooks(
 
 	ce->num_hooked_props++;
 
+	/* See zend_link_hooked_object_iter(). */
+#ifndef ZEND_WIN32
 	if (!ce->get_iterator) {
 		/* Will be removed again, in case of Iterator or IteratorAggregate. */
 		ce->get_iterator = zend_hooked_object_get_iterator;
 	}
+#endif
 
 	if (!prop_info->ce->parent_name) {
 		zend_verify_hooked_property(ce, prop_info, prop_name);
@@ -9104,6 +9107,10 @@ static void zend_compile_class_decl(znode *result, zend_ast *ast, bool toplevel)
 
 	/* We currently don't early-bind classes that implement interfaces or use traits */
 	if (!ce->num_interfaces && !ce->num_traits && !ce->num_hooked_prop_variance_checks
+#ifdef ZEND_WIN32
+	 /* See zend_link_hooked_object_iter(). */
+	 && !ce->num_hooked_props
+#endif
 	 && !(CG(compiler_options) & ZEND_COMPILE_WITHOUT_EXECUTION)) {
 		if (toplevel) {
 			if (extends_ast) {

Zend/zend_inheritance.c

@@ -3418,6 +3418,25 @@ static zend_class_entry *zend_lazy_class_load(zend_class_entry *pce)
 		} while (0)
 #endif
 
+#ifdef ZEND_WIN32
+/* Hooked properties set get_iterator, which causes issues on Windows. Windows
+ * attaches multiple processes to the same shm, with each process potentially
+ * having different addresses to the corresponding get_iterator function due to
+ * ASLR. This prevents us from caching the class.
+ *
+ * To at least cache the unlinked class, avoid early-binding on Windows, and set
+ * get_iterator during inheritance. The linked class may not use inheritance
+ * cache. */
+static void zend_link_hooked_object_iter(zend_class_entry *ce, bool *is_cacheable) {
+	if (!ce->get_iterator && ce->num_hooked_props) {
+		ce->get_iterator = zend_hooked_object_get_iterator;
+	}
+	if (ce->get_iterator) {
+		*is_cacheable = false;
+	}
+}
+#endif
+
 ZEND_API zend_class_entry *zend_do_link_class(zend_class_entry *ce, zend_string *lc_parent_name, zend_string *key) /* {{{ */
 {
 	/* Load parent/interface dependencies first, so we can still gracefully abort linking
@@ -3500,6 +3519,10 @@ ZEND_API zend_class_entry *zend_do_link_class(zend_class_entry *ce, zend_string
 	}
 #endif
 
+#ifdef ZEND_WIN32
+	zend_link_hooked_object_iter(ce, &is_cacheable);
+#endif
+
 	bool orig_record_errors = EG(record_errors);
 
 	if (ce->ce_flags & ZEND_ACC_IMMUTABLE && is_cacheable) {