Merge branch 'IS_MARIADB'

* IS_MARIADB:
  Deprecate MYSQLI_IS_MARIADB

Author: kamil-tekiela

UPGRADING

@@ -247,6 +247,7 @@ PHP 8.2 UPGRADE NOTES
     mysqli with libmysql and all relevant functionality has been removed.
   . The reconnect property of mysqli_driver has been removed. It was supported only by libmysql.
   . The INI directive mysqli.reconnect has been removed.
+  . The constant MYSQLI_IS_MARIADB has been deprecated.
 
 - OCI8:
   . The minimum Oracle Client library version required is now 11.2.

ext/mysqli/mysqli.stub.php

@@ -610,7 +610,10 @@
  */
 const MYSQLI_TRANS_COR_NO_RELEASE = UNKNOWN;
 
-/** @var bool */
+/**
+ * @var bool
+ * @deprecated
+ */
 const MYSQLI_IS_MARIADB = false;
 
 final class mysqli_driver

ext/mysqli/mysqli_arginfo.h

@@ -16,6 +16,7 @@ if (stristr(mysqli_get_client_info(), 'mysqlnd')) {
     print("\nDeprecated: Constant MYSQLI_SERVER_QUERY_WAS_SLOW is deprecated in dummy\n-1\n");
     print("\nDeprecated: Constant MYSQLI_SERVER_PS_OUT_PARAMS is deprecated in dummy\n-1\n");
 }
+echo constant('MYSQLI_IS_MARIADB')."\n";
 
 ?>
 --EXPECTF--
@@ -37,3 +38,5 @@ Deprecated: Constant MYSQLI_SERVER_QUERY_WAS_SLOW is deprecated in %s
 
 Deprecated: Constant MYSQLI_SERVER_PS_OUT_PARAMS is deprecated in %s
 %i
+
+Deprecated: Constant MYSQLI_IS_MARIADB is deprecated in %s

ext/mysqli/tests/deprecated_constants.phpt

@@ -47,6 +47,7 @@ $expected_constants = array(
     "MYSQLI_GROUP_FLAG" 				=> true,
     "MYSQLI_SERVER_QUERY_NO_GOOD_INDEX_USED"=> true,
     "MYSQLI_SERVER_QUERY_NO_INDEX_USED"	=> true,
+    "MYSQLI_OPT_LOAD_DATA_LOCAL_DIR"    => true,
     "MYSQLI_IS_MARIADB"                 => true,
 
     "MYSQLI_TYPE_DECIMAL"				=> true,
@@ -181,10 +182,6 @@ if ($IS_MYSQLND) {
     $expected_constants["MYSQLI_TYPE_JSON"]	= true;
 }
 
-if (($version > 80021 && $constants['mysqli']['MYSQLI_IS_MARIADB']) || $IS_MYSQLND) {
-    $expected_constants['MYSQLI_OPT_LOAD_DATA_LOCAL_DIR'] = true;
-}
-
 $unexpected_constants = array();
 
 foreach ($constants as $group => $consts) {