ext/pgsql: pgsql.allow_persistent, no need to use such large type for boolean state.

devnexen · devnexen · commit 09a1b03c1c50 · 2023-12-19T22:08:00.000Z
also ext/odbc, simplifying odd comparison with non persistent connections.
diff --git a/ext/odbc/php_odbc.c b/ext/odbc/php_odbc.c
@@ -2219,7 +2219,7 @@ void odbc_do_connect(INTERNAL_FUNCTION_PARAMETERS, int persistent)
 		}
 	}
 
-	if (ODBCG(allow_persistent) <= 0) {
+	if (!ODBCG(allow_persistent)) {
 		persistent = 0;
 	}
 
diff --git a/ext/pgsql/php_pgsql.h b/ext/pgsql/php_pgsql.h
@@ -184,7 +184,7 @@ static const php_stream_ops php_stream_pgsql_fd_ops = {
 ZEND_BEGIN_MODULE_GLOBALS(pgsql)
 	zend_long num_links,num_persistent;
 	zend_long max_links,max_persistent;
-	zend_long allow_persistent;
+	bool allow_persistent;
 	zend_long auto_reset_persistent;
 	int ignore_notices,log_notices;
 	zend_object *default_link; /* default link when connection is omitted */

Original file line number	Diff line number	Diff line change
`@@ -2219,7 +2219,7 @@ void odbc_do_connect(INTERNAL_FUNCTION_PARAMETERS, int persistent)`
`2219`	`2219`	`}`
`2220`	`2220`	`}`
`2221`	`2221`
`2222`		`- if (ODBCG(allow_persistent) <= 0) {`
	`2222`	`+ if (!ODBCG(allow_persistent)) {`
`2223`	`2223`	`persistent = 0;`
`2224`	`2224`	`}`
`2225`	`2225`