ext/sockets: socket_create_listen update.

going from 128 to system's SOMAXCONN by default to be able to increase
the queue of connections to be handled.
Also, for Haiku SOMAXCONN is only 32.

Close GH-13854

Author: devnexen

NEWS

@@ -198,6 +198,8 @@ PHP                                                                        NEWS
     SYN packets from the client. (David Carlier)
   . Added the SO_EXCLBIND constant for exclusive socket binding on illumos/solaris.
     (David Carlier)
+  . Updated the socket_create_listen backlog argument default value to SOMAXCONN.
+    (David Carlier)
 
 - SNMP:
   . Removed the deprecated inet_ntoa call support. (David Carlier)

UPGRADING

@@ -387,6 +387,10 @@ PHP 8.4 UPGRADE NOTES
   . posix_isatty now sets the error number when the file descriptor/stream argument
     is invalid.
 
+- Sockets:
+  . Parameter $backlog of socket_create_listen() now has a default value of SOMAXCONN.
+    Previously, it was 128.
+
 - SPL:
   . SplPriorityQueue::insert() and SplPriorityQueue::recoverFromCorruption()
     now has a tentative return type of true

ext/sockets/sockets.c

@@ -220,7 +220,7 @@ ZEND_GET_MODULE(sockets)
 static bool php_open_listen_sock(php_socket *sock, int port, int backlog) /* {{{ */
 {
 	struct sockaddr_in  la = {0};
-	struct hostent		*hp;
+	struct hostent	    *hp;
 
 #ifndef PHP_WIN32
 	if ((hp = php_network_gethostbyname("0.0.0.0")) == NULL) {
@@ -641,7 +641,7 @@ PHP_FUNCTION(socket_select)
 PHP_FUNCTION(socket_create_listen)
 {
 	php_socket	*php_sock;
-	zend_long		port, backlog = 128;
+	zend_long	port, backlog = SOMAXCONN;
 
 	if (zend_parse_parameters(ZEND_NUM_ARGS(), "l|l", &port, &backlog) == FAILURE) {
 		RETURN_THROWS();
@@ -764,7 +764,7 @@ PHP_FUNCTION(socket_listen)
 {
 	zval		*arg1;
 	php_socket	*php_sock;
-	zend_long		backlog = 0;
+	zend_long	backlog = 0;
 
 	if (zend_parse_parameters(ZEND_NUM_ARGS(), "O|l", &arg1, socket_ce, &backlog) == FAILURE) {
 		RETURN_THROWS();

ext/sockets/sockets.stub.php

@@ -1885,7 +1885,7 @@ final class AddressInfo
 
 function socket_select(?array &$read, ?array &$write, ?array &$except, ?int $seconds, int $microseconds = 0): int|false {}
 
-function socket_create_listen(int $port, int $backlog = 128): Socket|false {}
+function socket_create_listen(int $port, int $backlog = SOMAXCONN): Socket|false {}
 
 function socket_accept(Socket $socket): Socket|false {}