Skip to content

Commit 104b7ad

Browse files
committed
Remove unused recv_arg_info from func_info
1 parent ce22cf5 commit 104b7ad

File tree

3 files changed

+2
-40
lines changed

3 files changed

+2
-40
lines changed

ext/opcache/Optimizer/zend_call_graph.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,6 @@ typedef struct _zend_send_arg_info {
2727
zend_op *opline;
2828
} zend_send_arg_info;
2929

30-
typedef struct _zend_recv_arg_info {
31-
int ssa_var;
32-
zend_ssa_var_info info;
33-
} zend_recv_arg_info;
34-
3530
struct _zend_call_info {
3631
zend_op_array *caller_op_array;
3732
zend_op *caller_init_opline;
@@ -55,7 +50,6 @@ struct _zend_func_info {
5550
zend_call_info **call_map; /* Call info associated with init/call/send opnum */
5651
int num_args; /* (-1 - unknown) */
5752
int return_value_used; /* -1 unknown, 0 no, 1 yes */
58-
zend_recv_arg_info *arg_info;
5953
zend_ssa_var_info return_info;
6054
};
6155

ext/opcache/Optimizer/zend_dump.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -969,17 +969,6 @@ void zend_dump_op_array(const zend_op_array *op_array, uint32_t dump_flags, cons
969969
}
970970
fprintf(stderr, " ; %s:%u-%u\n", op_array->filename->val, op_array->line_start, op_array->line_end);
971971

972-
if (func_info && func_info->num_args > 0) {
973-
uint32_t j;
974-
975-
for (j = 0; j < MIN(op_array->num_args, func_info->num_args ); j++) {
976-
fprintf(stderr, " ; arg %d ", j);
977-
zend_dump_type_info(func_info->arg_info[j].info.type, func_info->arg_info[j].info.ce, func_info->arg_info[j].info.is_instanceof, dump_flags);
978-
zend_dump_range(&func_info->arg_info[j].info.range);
979-
fprintf(stderr, "\n");
980-
}
981-
}
982-
983972
if (func_info) {
984973
fprintf(stderr, " ; return ");
985974
zend_dump_type_info(func_info->return_info.type, func_info->return_info.ce, func_info->return_info.is_instanceof, dump_flags);

ext/opcache/Optimizer/zend_inference.c

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1398,14 +1398,7 @@ int zend_inference_calc_range(const zend_op_array *op_array, zend_ssa *ssa, int
13981398
case ZEND_RECV:
13991399
case ZEND_RECV_INIT:
14001400
if (ssa_op->result_def == var) {
1401-
zend_func_info *func_info = ZEND_FUNC_INFO(op_array);
1402-
1403-
if (func_info &&
1404-
(int)opline->op1.num-1 < func_info->num_args &&
1405-
func_info->arg_info[opline->op1.num-1].info.has_range) {
1406-
*tmp = func_info->arg_info[opline->op1.num-1].info.range;
1407-
return 1;
1408-
} else if (op_array->arg_info &&
1401+
if (op_array->arg_info &&
14091402
opline->op1.num <= op_array->num_args) {
14101403
zend_type type = op_array->arg_info[opline->op1.num-1].type;
14111404
uint32_t mask = ZEND_TYPE_PURE_MASK_WITHOUT_NULL(type);
@@ -3005,7 +2998,6 @@ static zend_always_inline int _zend_update_type_info(
30052998
case ZEND_RECV_INIT:
30062999
{
30073000
/* Typehinting */
3008-
zend_func_info *func_info;
30093001
zend_arg_info *arg_info = &op_array->arg_info[opline->op1.num-1];
30103002

30113003
ce = NULL;
@@ -3014,21 +3006,8 @@ static zend_always_inline int _zend_update_type_info(
30143006
tmp |= MAY_BE_REF;
30153007
}
30163008

3017-
func_info = ZEND_FUNC_INFO(op_array);
3018-
if (func_info && (int)opline->op1.num-1 < func_info->num_args) {
3019-
tmp = (tmp & (MAY_BE_RC1|MAY_BE_RCN|MAY_BE_REF)) |
3020-
(tmp & func_info->arg_info[opline->op1.num-1].info.type);
3021-
}
3022-
30233009
UPDATE_SSA_TYPE(tmp, ssa_op->result_def);
3024-
if (func_info &&
3025-
(int)opline->op1.num-1 < func_info->num_args &&
3026-
func_info->arg_info[opline->op1.num-1].info.ce) {
3027-
UPDATE_SSA_OBJ_TYPE(
3028-
func_info->arg_info[opline->op1.num-1].info.ce,
3029-
func_info->arg_info[opline->op1.num-1].info.is_instanceof,
3030-
ssa_op->result_def);
3031-
} else if (ce) {
3010+
if (ce) {
30323011
UPDATE_SSA_OBJ_TYPE(ce, 1, ssa_op->result_def);
30333012
} else {
30343013
UPDATE_SSA_OBJ_TYPE(NULL, 0, ssa_op->result_def);

0 commit comments

Comments
 (0)