Skip to content

Commit 114c03b

Browse files
committed
Fix #78623: Regression caused by "SP call yields additional empty result set"
This reverts commit 41a4379.
1 parent 545412a commit 114c03b

File tree

5 files changed

+12
-2
lines changed

5 files changed

+12
-2
lines changed

NEWS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ PHP NEWS
2121
. Fixed bug #76809 (SSL settings aren't respected when persistent connections
2222
are used). (fabiomsouto)
2323

24+
- PDO_MySQL:
25+
. Fixed bug #78623 (Regression caused by "SP call yields additional empty
26+
result set"). (cmb)
27+
2428
- Session:
2529
. Fixed bug #78624 (session_gc return value for user defined session
2630
handlers). (bshaffer)

ext/pdo_mysql/mysql_statement.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -425,14 +425,14 @@ static int pdo_mysql_stmt_next_rowset(pdo_stmt_t *stmt) /* {{{ */
425425
pdo_mysql_error_stmt(stmt);
426426
PDO_DBG_RETURN(0);
427427
} else {
428-
PDO_DBG_RETURN(pdo_mysql_fill_stmt_from_result(stmt) && stmt->row_count);
428+
PDO_DBG_RETURN(pdo_mysql_fill_stmt_from_result(stmt));
429429
}
430430
#else
431431
if (mysql_next_result(H->server) > 0) {
432432
pdo_mysql_error_stmt(stmt);
433433
PDO_DBG_RETURN(0);
434434
} else {
435-
PDO_DBG_RETURN(pdo_mysql_fill_stmt_from_result(stmt) && stmt->row_count);
435+
PDO_DBG_RETURN(pdo_mysql_fill_stmt_from_result(stmt));
436436
}
437437
#endif
438438
}

ext/pdo_mysql/tests/bug_39858.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ if ($version < 50000)
1818
die(sprintf("skip Need MySQL Server 5.0.0+, found %d.%02d.%02d (%d)\n",
1919
$matches[0], $matches[1], $matches[2], $version));
2020
?>
21+
--XFAIL--
22+
nextRowset() problem with stored proc & emulation mode & mysqlnd
2123
--FILE--
2224
<?php
2325
require_once(dirname(__FILE__) . DIRECTORY_SEPARATOR . 'mysql_pdo_test.inc');

ext/pdo_mysql/tests/bug_41997.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
--TEST--
22
PDO MySQL Bug #41997 (stored procedure call returning single rowset blocks future queries)
3+
--XFAIL--
4+
nextRowset() problem with stored proc & emulation mode & mysqlnd
35
--SKIPIF--
46
<?php
57
require_once(dirname(__FILE__) . DIRECTORY_SEPARATOR . 'skipif.inc');

ext/pdo_mysql/tests/pdo_mysql_stmt_variable_columncount.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
--TEST--
22
MySQL Prepared Statements and different column counts
3+
--XFAIL--
4+
nextRowset() problem with stored proc & emulation mode & mysqlnd
35
--SKIPIF--
46
<?php
57
require_once(dirname(__FILE__) . DIRECTORY_SEPARATOR . 'skipif.inc');

0 commit comments

Comments
 (0)