Skip to content

Commit 1357d1e

Browse files
committed
Fix test for GH-10908
It turns out that the version of Firebird influences the test in terms of supported data types. On Windows on 8.2 we seem to be using a different version than on 8.1. Fix it by amending the test. The core issue is still tested in the test, it's just that not all datatypes are tested anymore (which isn't strictly necessary anyway).
1 parent 69c57be commit 1357d1e

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

ext/pdo_firebird/tests/gh10908.phpt

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,17 +22,14 @@ CREATE TABLE gh10908(
2222
MYDATE DATE,
2323
MYTIME TIME,
2424
MYBLOB BLOB,
25-
MYBINARY BINARY(2),
26-
MYVARBINARY VARBINARY(2),
2725
MYSMALLINT SMALLINT,
2826
MYINT INT,
2927
MYCHAR CHAR(10),
30-
MYVARCHAR VARCHAR(5),
3128
MYBOOL BOOLEAN
3229
);
3330
EOT;
3431
$dbh->exec($sql);
35-
$dbh->exec("INSERT INTO gh10908 VALUES(1, 'ABC', 12.34, 1.0, 2.0, '2023-03-24 17:39', '2023-03-24', '17:39', 'abcdefg', 'ab', 'a', 32767, 200000, 'azertyuiop', 'ab', false);");
32+
$dbh->exec("INSERT INTO gh10908 VALUES(1, 'ABC', 12.34, 1.0, 2.0, '2023-03-24 17:39', '2023-03-24', '17:39', 'abcdefg', 32767, 200000, 'azertyuiop', false);");
3633

3734
function query_and_dump($dbh, $sql) {
3835
foreach ($dbh->query($sql) as $row) {
@@ -118,20 +115,14 @@ Array
118115
[7] => 17:39:00
119116
[MYBLOB] => abcdefg
120117
[8] => abcdefg
121-
[MYBINARY] => ab
122-
[9] => ab
123-
[MYVARBINARY] => a
124-
[10] => a
125118
[MYSMALLINT] => 32767
126-
[11] => 32767
119+
[9] => 32767
127120
[MYINT] => 200000
128-
[12] => 200000
121+
[10] => 200000
129122
[MYCHAR] => azertyuiop
130-
[13] => azertyuiop
131-
[MYVARCHAR] => ab
132-
[14] => ab
123+
[11] => azertyuiop
133124
[MYBOOL] =>
134-
[15] =>
125+
[12] =>
135126
)
136127

137128
Array

0 commit comments

Comments
 (0)