Skip to content

Commit 19314ff

Browse files
committed
Fix some tests for libmysql
1 parent 2d00225 commit 19314ff

8 files changed

+35
-12
lines changed

ext/mysqli/tests/bug66043.phpt

Lines changed: 24 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,6 @@ Bug #66043 (Segfault calling bind_param() on mysqli)
33
--SKIPIF--
44
<?php
55
require_once('skipif.inc');
6-
require_once("connect.inc");
7-
if ($IS_MYSQLND) {
8-
die("skip libmysql only test");
9-
}
106
require_once('skipifconnectfailure.inc');
117
?>
128
--FILE--
@@ -16,11 +12,34 @@ if (!$db = my_mysqli_connect($host, $user, $passwd, $db, $port, $socket)) {
1612
printf("[001] Connect failed, [%d] %s\n", mysqli_connect_errno(), mysqli_connect_error());
1713
}
1814

15+
if (!$db->query("DROP TABLE IF EXISTS test")) {
16+
printf("[002] [%d] %s\n", mysqli_errno($db), mysqli_error($db));
17+
die();
18+
}
19+
20+
if (!$db->query("CREATE TABLE test(str TEXT)")) {
21+
printf("[003] [%d] %s\n", mysqli_errno($db), mysqli_error($db));
22+
die();
23+
}
24+
25+
if (!$db->query("INSERT INTO test(str) VALUES ('Test')")) {
26+
printf("[004] [%d] %s\n", mysqli_errno($link), mysqli_error($link));
27+
die();
28+
}
29+
1930
$stmt = $db->stmt_init();
20-
$stmt->prepare("SELECT User FROM user WHERE password=\"\"");
31+
if (!$stmt->prepare("SELECT str FROM test")) {
32+
printf("[004] [%d] %s\n", mysqli_errno($db), mysqli_error($db));
33+
die();
34+
}
35+
2136
$stmt->execute();
2237
$stmt->bind_result($testArg);
2338
echo "Okey";
2439
?>
40+
--CLEAN--
41+
<?php
42+
require_once("clean_table.inc");
43+
?>
2544
--EXPECT--
2645
Okey

ext/mysqli/tests/bug73800.phpt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Bug #73800 (sporadic segfault with MYSQLI_OPT_INT_AND_FLOAT_NATIVE)
55
require_once('skipif.inc');
66
require_once('skipifconnectfailure.inc');
77
if (PHP_INT_SIZE != 8) die('skip requires 64-bit');
8+
if (!defined('MYSQLI_OPT_INT_AND_FLOAT_NATIVE')) die('skip requires mysqlnd');
89
?>
910
--FILE--
1011
<?php

ext/mysqli/tests/bug77597.phpt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Bug #77597: mysqli_fetch_field hangs scripts
44
<?php
55
require_once('skipif.inc');
66
require_once('skipifconnectfailure.inc');
7+
if (!defined('MYSQLI_STORE_RESULT_COPY_DATA')) die('skip requires mysqlnd');
78
?>
89
--FILE--
910
<?php

ext/mysqli/tests/mysqli_class_mysqli_properties_no_conn.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ Magic, magic properties:
284284
mysqli object is already closed
285285
Property access is not allowed yet
286286
Property access is not allowed yet
287-
mysqli->client_version = '80000'/integer
287+
mysqli->client_version = '%d'/integer
288288
mysqli object is already closed
289289
mysqli object is already closed
290290
mysqli object is already closed
@@ -366,7 +366,7 @@ Magic, magic properties:
366366
mysqli object is already closed
367367
Property access is not allowed yet
368368
Property access is not allowed yet
369-
mysqli->client_version = '80000'/integer
369+
mysqli->client_version = '%d'/integer
370370
mysqli object is already closed
371371
mysqli object is already closed
372372
mysqli object is already closed

ext/mysqli/tests/mysqli_kill.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,15 +95,15 @@ object(mysqli)#%d (%d) {
9595
["connect_error"]=>
9696
NULL
9797
["errno"]=>
98-
int(2006)
98+
int(%d)
9999
["error"]=>
100100
string(%d) "%s"
101101
["error_list"]=>
102102
array(1) {
103103
[0]=>
104104
array(3) {
105105
["errno"]=>
106-
int(2006)
106+
int(%d)
107107
["sqlstate"]=>
108108
string(5) "%s"
109109
["error"]=>

ext/mysqli/tests/mysqli_store_result_buffered_c.phpt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@ mysqli_store_result()
44
<?php
55
require_once('skipif.inc');
66
require_once('skipifconnectfailure.inc');
7+
if (!defined('MYSQLI_STORE_RESULT_COPY_DATA')) {
8+
die("skip Requires MYSQLI_STORE_RESULT_COPY_DATA");
9+
}
710
?>
8-
--INI--
9-
mysqlnd.debug="d:t:O,{TMP}/mysqlnd.trace"
1011
--FILE--
1112
<?php
1213
require_once("connect.inc");

ext/pdo_mysql/tests/pdo_mysql___construct_uri.phpt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ MySQLPDOTest::skip();
4848
} catch (PDOException $e) {
4949
$expected = array(
5050
"SQLSTATE[HY000] [1049] Unknown database 'letshopeinvalid'",
51+
"SQLSTATE[42000] [1049] Unknown database 'letshopeinvalid'",
5152
"SQLSTATE[HY000] [2002] No such file or directory"
5253
);
5354
printf("[003] URI=%s, DSN=%s, File=%s (%d bytes, '%s'), chr(0) test, %s\n",

ext/pdo_mysql/tests/pdo_mysql_class_constants.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ if (!extension_loaded('mysqli') && !extension_loaded('mysqlnd')) {
2727
"MYSQL_ATTR_SSL_CIPHER" => true,
2828
"MYSQL_ATTR_COMPRESS" => true,
2929
"MYSQL_ATTR_MULTI_STATEMENTS" => true,
30-
"MYSQL_ATTR_SSL_VERIFY_SERVER_CERT" => true,
3130
);
3231

3332
if (!MySQLPDOTest::isPDOMySQLnd()) {
@@ -37,6 +36,7 @@ if (!extension_loaded('mysqli') && !extension_loaded('mysqlnd')) {
3736
}
3837

3938
if (extension_loaded('mysqlnd')) {
39+
$expected['MYSQL_ATTR_SSL_VERIFY_SERVER_CERT'] = true;
4040
$expected['MYSQL_ATTR_SERVER_PUBLIC_KEY'] = true;
4141
} else if (extension_loaded('mysqli')) {
4242
if (mysqli_get_client_version() > 50605) {

0 commit comments

Comments
 (0)