Ammend error output stream to circumvent wrong usage of zend_bool

Author: Girgias

main/main.c

@@ -447,9 +447,9 @@ static PHP_INI_MH(OnUpdateTimeout)
 
 /* {{{ php_get_display_errors_mode() helper function
  */
-static int php_get_display_errors_mode(char *value, size_t value_length)
+static unsigned int php_get_display_errors_mode(char *value, size_t value_length)
 {
-	int mode;
+	unsigned int mode;
 
 	if (!value) {
 		return PHP_DISPLAY_ERRORS_STDOUT;
@@ -480,7 +480,12 @@ static int php_get_display_errors_mode(char *value, size_t value_length)
  */
 static PHP_INI_MH(OnUpdateDisplayErrors)
 {
-	PG(display_errors) = (zend_bool) php_get_display_errors_mode(ZSTR_VAL(new_value), ZSTR_LEN(new_value));
+	PG(errors_output_stream) = php_get_display_errors_mode(ZSTR_VAL(new_value), ZSTR_LEN(new_value));
+	if (PG(errors_output_stream) > 0) {
+		PG(display_errors) = true;
+	} else {
+		PG(display_errors) = false;
+	}
 
 	return SUCCESS;
 }
@@ -490,7 +495,8 @@ static PHP_INI_MH(OnUpdateDisplayErrors)
  */
 static PHP_INI_DISP(display_errors_mode)
 {
-	int mode, cgi_or_cli;
+	unsigned int mode;
+	bool cgi_or_cli;
 	size_t tmp_value_length;
 	char *tmp_value;
 
@@ -1342,7 +1348,7 @@ static ZEND_COLD void php_error_cb(int orig_type, const char *error_filename, co
 				} else {
 					/* Write CLI/CGI errors to stderr if display_errors = "stderr" */
 					if ((!strcmp(sapi_module.name, "cli") || !strcmp(sapi_module.name, "cgi") || !strcmp(sapi_module.name, "phpdbg")) &&
-						PG(display_errors) == PHP_DISPLAY_ERRORS_STDERR
+						PG(errors_output_stream) == PHP_DISPLAY_ERRORS_STDERR
 					) {
 						fprintf(stderr, "%s: %s in %s on line %" PRIu32 "\n", error_type_str, ZSTR_VAL(message), error_filename, error_lineno);
 #ifdef PHP_WIN32

main/php_globals.h

@@ -65,6 +65,7 @@ struct _php_core_globals {
 	zend_long memory_limit;
 	zend_long max_input_time;
 
+	unsigned int errors_output_stream;
 	zend_bool display_errors;
 	zend_bool display_startup_errors;
 	zend_bool log_errors;