refactor: edited and added tests according to list feedback

Author: NickSdot

Zend/tests/property_hooks/readonly_backed_property.phpt

@@ -0,0 +1,41 @@
+--TEST--
+Backed property, readonly class
+--FILE--
+<?php
+
+// readonly class
+readonly class Test {
+    public int $prop {
+        get => $this->prop;
+        set => $value;
+    }
+
+    public function __construct(int $v) {
+        $this->prop = $v;
+    }
+
+    public function set($v)
+    {
+         $this->prop = $v;
+    }
+}
+
+$t = new Test(42);
+var_dump($t->prop);
+try {
+    $t->set(43);
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+try {
+    $t->prop = 43;
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+var_dump($t->prop);
+?>
+--EXPECT--
+int(42)
+Cannot modify readonly property Test::$prop
+Cannot modify protected(set) readonly property Test::$prop from global scope
+int(42)

Zend/tests/property_hooks/readonly_class_property_backed.phpt

@@ -0,0 +1,21 @@
+--TEST--
+Backed property cannot redeclare readonly as non-readonly property
+--FILE--
+<?php
+
+readonly class ParentClass {
+    public int $prop;
+}
+
+class Test extends ParentClass {
+    public function __construct(
+        public int $prop {
+            get => $this->prop;
+            set => $value;
+        }
+    ) {}
+}
+
+?>
+--EXPECTF--
+Fatal error: Non-readonly class Test cannot extend readonly class ParentClass in %s on line %d

Zend/tests/property_hooks/readonly_class_property_backed_inheritance_1.phpt

@@ -0,0 +1,21 @@
+--TEST--
+Backed property cannot redeclare non-readonly as readonly property
+--FILE--
+<?php
+
+class ParentClass {
+    public int $prop;
+}
+
+readonly class Test extends ParentClass {
+    public function __construct(
+        public int $prop {
+            get => $this->prop;
+            set => $value;
+        }
+    ) {}
+}
+
+?>
+--EXPECTF--
+Fatal error: Readonly class Test cannot extend non-readonly class ParentClass in %s on line %d

Zend/tests/property_hooks/readonly_class_property_backed_inheritance_2.phpt

@@ -0,0 +1,40 @@
+--TEST--
+Backed property, promoted, readonly class
+--FILE--
+<?php
+
+// readonly class, promoted
+readonly class Test {
+    public function __construct(
+        public int $prop {
+            get => $this->prop;
+            set => $value;
+        }
+    ) {}
+
+    public function set($v)
+    {
+         $this->prop = $v;
+    }
+}
+
+$t = new Test(42);
+var_dump($t->prop);
+try {
+    $t->set(43);
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+try {
+    $t->prop = 43;
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+var_dump($t->prop);
+?>
+--EXPECT--
+int(42)
+Cannot modify readonly property Test::$prop
+Cannot modify protected(set) readonly property Test::$prop from global scope
+int(42)
+

Zend/tests/property_hooks/readonly_class_property_backed_promoted.phpt

@@ -0,0 +1,68 @@
+--TEST--
+Readonly hooks may be lazy loaded
+--FILE--
+<?php
+
+interface DbConnection {
+   public function loadCategory(string $id): Category;
+}
+
+class Category {
+   public function __construct(public string $name) {}
+}
+
+class MockDbConnection implements DbConnection {
+   public function loadCategory(string $id): Category {
+       echo "hit database\n";
+       return new Category("Category {$id}");
+   }
+}
+
+readonly class LazyProduct
+{
+   private DbConnection $dbApi;
+   private string $categoryId;
+
+   public Category $category {
+       get {
+           return $this->category ??= $this->dbApi->loadCategory($this->categoryId);
+       }
+   }
+}
+
+$product = new LazyProduct();
+$reflect = new ReflectionClass($product);
+
+$db = $reflect->getProperty('dbApi');
+$db->setAccessible(true);
+$db->setValue($product, new MockDbConnection());
+
+$categoryId = $reflect->getProperty('categoryId');
+$categoryId->setAccessible(true);
+$categoryId->setValue($product, '42');
+
+// lazy loading, hit db
+$category1 = $product->category;
+echo $category1->name . "\n";
+
+// cached category returned
+$category2 = $product->category;
+echo $category2->name . "\n";
+
+// same category instance returned
+var_dump($category1 === $category2);
+
+// cannot set twice
+try {
+    $categoryId->setValue($product, '420');
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+
+?>
+--EXPECT--
+hit database
+Category 42
+Category 42
+bool(true)
+Cannot modify readonly property LazyProduct::$categoryId

Zend/tests/property_hooks/readonly_virtual_property_promoted_class.phpt renamed to Zend/tests/property_hooks/readonly_class_property_virtual_promoted.phpt

@@ -0,0 +1,41 @@
+--TEST--
+Backed readonly property may have hooks
+--FILE--
+<?php
+
+// readonly property
+class Test {
+    public readonly int $prop {
+        get => $this->prop;
+        set => $value;
+    }
+
+    public function __construct(int $v) {
+        $this->prop = $v;
+    }
+
+    public function set($v)
+    {
+         $this->prop = $v;
+    }
+}
+
+$t = new Test(42);
+var_dump($t->prop);
+try {
+    $t->set(43);
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+try {
+    $t->prop = 43;
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+var_dump($t->prop);
+?>
+--EXPECT--
+int(42)
+Cannot modify readonly property Test::$prop
+Cannot modify protected(set) readonly property Test::$prop from global scope
+int(42)

Zend/tests/property_hooks/readonly_lazy.phpt

@@ -0,0 +1,21 @@
+--TEST--
+Backed property cannot redeclare readonly as non-readonly property
+--FILE--
+<?php
+
+class ParentClass {
+    public readonly int $prop;
+}
+
+class Test extends ParentClass {
+    public function __construct(
+        public int $prop {
+            get => $this->prop;
+            set => $value;
+        }
+    ) {}
+}
+
+?>
+--EXPECTF--
+Fatal error: Cannot redeclare readonly property ParentClass::$prop as non-readonly Test::$prop %s on line %d

Zend/tests/property_hooks/readonly_property_backed.phpt

@@ -0,0 +1,21 @@
+--TEST--
+Backed property cannot redeclare non-readonly as readonly property
+--FILE--
+<?php
+
+class ParentClass {
+    public int $prop;
+}
+
+class Test extends ParentClass {
+    public function __construct(
+        public readonly int $prop {
+            get => $this->prop;
+            set => $value;
+        }
+    ) {}
+}
+
+?>
+--EXPECTF--
+Fatal error: Cannot redeclare non-readonly property ParentClass::$prop as readonly Test::$prop in %s on line %d