Skip to content

Commit 1afecb6

Browse files
committed
TODO Comment
1 parent 3c7e791 commit 1afecb6

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

ext/xml/xml.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,6 +1114,7 @@ PHP_FUNCTION(xml_set_element_handler)
11141114
zend_string *method_name = NULL;
11151115
zend_string *method_name2 = NULL;
11161116

1117+
// TODO: cover trampolines with tests, as the !ZEND_FCC_INITIALIZED branches are never executed right now
11171118
if (zend_parse_parameters_ex(ZEND_PARSE_PARAMS_QUIET, ZEND_NUM_ARGS(), "Of!f!", &pind, xml_parser_ce, &start_fci, &start_fcc, &end_fci, &end_fcc) == SUCCESS) {
11181119
parser = Z_XMLPARSER_P(pind);
11191120
if (ZEND_FCI_INITIALIZED(start_fci) && !ZEND_FCC_INITIALIZED(start_fcc)) {

0 commit comments

Comments
 (0)