changes from reviews

Author: devnexen

ext/pgsql/pgsql.c

@@ -4553,7 +4553,7 @@ PHP_PGSQL_API zend_result php_pgsql_convert(PGconn *pg_link, const zend_string *
 								ZVAL_STRINGL(&new_val, "'f'", sizeof("'f'")-1);
 							}
 							else {
-								zend_value_error("Detected invalid value (%s) for PostgreSQL '%s' field (%s)", Z_STRVAL_P(val), Z_STRVAL_P(type), ZSTR_VAL(field));
+								zend_value_error("Expects valid boolean value for PostgreSQL '%s' field (%s), got `%s`", Z_STRVAL_P(type), ZSTR_VAL(field), Z_STRVAL_P(val));
 								err = 1;
 							}
 						}
@@ -4819,7 +4819,7 @@ PHP_PGSQL_API zend_result php_pgsql_convert(PGconn *pg_link, const zend_string *
 				}
 				PGSQL_CONV_CHECK_IGNORE();
 				if (err) {
-					zend_type_error("Expects IPv4, IPv6 or null for PostgreSQL '%s' (%s)", Z_STRVAL_P(type), ZSTR_VAL(field));
+					zend_value_error("Expects IPv4, IPv6 or null for PostgreSQL '%s' (%s)", Z_STRVAL_P(type), ZSTR_VAL(field));
 				}
 				break;
 

ext/pgsql/tests/bug71998.phpt

@@ -60,7 +60,7 @@ foreach ($ips as $ip) {
     $r = true;
     try {
     	@pg_insert($db, 'tmp_statistics', $data);
-    } catch (\TypeError $e) {
+    } catch (\ValueError $e) {
         $r = false;
     }
 

ext/pgsql/tests/bug77047.phpt

@@ -20,19 +20,19 @@ pg_query($db, "CREATE TABLE bug77047 (
     )");
 
 try {
-	pg_insert($db, "bug77047", array("t" => "13:31"));
-	pg_insert($db, "bug77047", array("t" => "13:31:13"));
-	pg_insert($db, "bug77047", array("t" => "1:2:3"));
-	pg_insert($db, "bug77047", array("t" => "xyz"));
-	pg_insert($db, "bug77047", array("t" => NULL));
-	pg_insert($db, "bug77047", array("t" => ""));
+    pg_insert($db, "bug77047", array("t" => "13:31"));
+    pg_insert($db, "bug77047", array("t" => "13:31:13"));
+    pg_insert($db, "bug77047", array("t" => "1:2:3"));
+    pg_insert($db, "bug77047", array("t" => "xyz"));
+    pg_insert($db, "bug77047", array("t" => NULL));
+    pg_insert($db, "bug77047", array("t" => ""));
 } catch (\TypeError $e) {
 	echo $e->getMessage();
 }
 
 $res = pg_query($db, "SELECT t FROM bug77047");
 while (false !== ($row = pg_fetch_row($res))) {
-	var_dump(array_pop($row));
+    var_dump(array_pop($row));
 }
 
 ?>