Skip to content

Commit 1f432c8

Browse files
committed
Micro optimization
1 parent b75bd26 commit 1f432c8

File tree

2 files changed

+12
-15
lines changed

2 files changed

+12
-15
lines changed

Zend/zend_vm_def.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3124,12 +3124,11 @@ ZEND_VM_HANDLER(67, ZEND_SEND_REF, VAR|CV, ANY)
31243124
ZVAL_COPY_VALUE(arg, varptr);
31253125
} else if (OP1_TYPE == IS_VAR &&
31263126
UNEXPECTED(Z_TYPE_P(EX_VAR(opline->op1.var)) != IS_INDIRECT)) {
3127-
ZVAL_COPY_VALUE(arg, varptr);
3128-
ZVAL_MAKE_REF(arg);
3127+
ZVAL_NEW_REF(arg, varptr);
31293128
} else {
3130-
ZVAL_MAKE_REF(varptr);
3131-
Z_ADDREF_P(varptr);
3132-
ZVAL_REF(arg, Z_REF_P(varptr));
3129+
ZVAL_NEW_REF(arg, varptr);
3130+
Z_ADDREF_P(arg);
3131+
ZVAL_REF(varptr, Z_REF_P(arg));
31333132
}
31343133

31353134
FREE_OP1_VAR_PTR();

Zend/zend_vm_execute.h

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16544,12 +16544,11 @@ static int ZEND_FASTCALL ZEND_SEND_REF_SPEC_VAR_HANDLER(ZEND_OPCODE_HANDLER_ARG
1654416544
ZVAL_COPY_VALUE(arg, varptr);
1654516545
} else if (IS_VAR == IS_VAR &&
1654616546
UNEXPECTED(Z_TYPE_P(EX_VAR(opline->op1.var)) != IS_INDIRECT)) {
16547-
ZVAL_COPY_VALUE(arg, varptr);
16548-
ZVAL_MAKE_REF(arg);
16547+
ZVAL_NEW_REF(arg, varptr);
1654916548
} else {
16550-
ZVAL_MAKE_REF(varptr);
16551-
Z_ADDREF_P(varptr);
16552-
ZVAL_REF(arg, Z_REF_P(varptr));
16549+
ZVAL_NEW_REF(arg, varptr);
16550+
Z_ADDREF_P(arg);
16551+
ZVAL_REF(varptr, Z_REF_P(arg));
1655316552
}
1655416553

1655516554
if (free_op1.var) {zval_ptr_dtor_nogc(free_op1.var);};
@@ -34339,12 +34338,11 @@ static int ZEND_FASTCALL ZEND_SEND_REF_SPEC_CV_HANDLER(ZEND_OPCODE_HANDLER_ARGS
3433934338
ZVAL_COPY_VALUE(arg, varptr);
3434034339
} else if (IS_CV == IS_VAR &&
3434134340
UNEXPECTED(Z_TYPE_P(EX_VAR(opline->op1.var)) != IS_INDIRECT)) {
34342-
ZVAL_COPY_VALUE(arg, varptr);
34343-
ZVAL_MAKE_REF(arg);
34341+
ZVAL_NEW_REF(arg, varptr);
3434434342
} else {
34345-
ZVAL_MAKE_REF(varptr);
34346-
Z_ADDREF_P(varptr);
34347-
ZVAL_REF(arg, Z_REF_P(varptr));
34343+
ZVAL_NEW_REF(arg, varptr);
34344+
Z_ADDREF_P(arg);
34345+
ZVAL_REF(varptr, Z_REF_P(arg));
3434834346
}
3434934347

3435034348
ZEND_VM_NEXT_OPCODE();

0 commit comments

Comments
 (0)