Check the return value of lo_export.

LawnGnome · LawnGnome · commit 211f4ceeaec6 · 2014-12-30T17:47:19.000Z
Patch by Ondřej Surý. Fixes bug #68697 (lo_export return -1 on failure).
diff --git a/NEWS b/NEWS
@@ -47,6 +47,9 @@ PHP                                                                        NEWS
   . Fixed bug #66679 (Alignment Bug in PCRE 8.34 upstream).
     (Rainer Jung, Anatol Belski)
 
+- pgsql:
+  . Fixed bug #68697 (lo_export return -1 on failure). (Ondřej Surý)
+
 - PDO_mysql
   . Fixed bug #68424 (Add new PDO mysql connection attr to control multi
     statements option). (peter dot wolanin at acquia dot com)
diff --git a/ext/pgsql/pgsql.c b/ext/pgsql/pgsql.c
@@ -3631,10 +3631,10 @@ PHP_FUNCTION(pg_lo_export)
 
 	ZEND_FETCH_RESOURCE2(pgsql, PGconn *, &pgsql_link, id, "PostgreSQL link", le_link, le_plink);
 
-	if (lo_export(pgsql, oid, file_out)) {
-		RETURN_TRUE;
+	if (lo_export(pgsql, oid, file_out) == -1) {
+		RETURN_FALSE;
 	}
-	RETURN_FALSE;
+	RETURN_TRUE;
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -3631,10 +3631,10 @@ PHP_FUNCTION(pg_lo_export)`
`3631`	`3631`
`3632`	`3632`	`ZEND_FETCH_RESOURCE2(pgsql, PGconn *, &pgsql_link, id, "PostgreSQL link", le_link, le_plink);`
`3633`	`3633`
`3634`		`- if (lo_export(pgsql, oid, file_out)) {`
`3635`		`- RETURN_TRUE;`
	`3634`	`+ if (lo_export(pgsql, oid, file_out) == -1) {`
	`3635`	`+ RETURN_FALSE;`
`3636`	`3636`	`}`
`3637`		`- RETURN_FALSE;`
	`3637`	`+ RETURN_TRUE;`
`3638`	`3638`	`}`
`3639`	`3639`	`/* }}} */`
`3640`	`3640`