fcgi_is_allowed should not log error

laruence · laruence · commit 231f059d8c6b · 2015-05-24T14:21:04.000+08:00
diff --git a/main/fastcgi.c b/main/fastcgi.c
@@ -1239,7 +1239,6 @@ static int fcgi_is_allowed() {
 	}
 #endif
 
-	fcgi_log(FCGI_ERROR, "Connection disallowed: IP address '%s' has been dropped.", fcgi_get_last_client_ip());
 	return 0;
 }
 
@@ -1296,6 +1295,7 @@ FCGI_API int fcgi_accept_request(fcgi_request *req)
 
 					client_sa = sa;
 					if (req->fd >= 0 && !fcgi_is_allowed()) {
+						fcgi_log(FCGI_ERROR, "Connection disallowed: IP address '%s' has been dropped.", fcgi_get_last_client_ip());
 						closesocket(req->fd);
 						req->fd = -1;
 						continue;

Original file line number	Diff line number	Diff line change
`@@ -1239,7 +1239,6 @@ static int fcgi_is_allowed() {`
`1239`	`1239`	`}`
`1240`	`1240`	`#endif`
`1241`	`1241`
`1242`		`- fcgi_log(FCGI_ERROR, "Connection disallowed: IP address '%s' has been dropped.", fcgi_get_last_client_ip());`
`1243`	`1242`	`return 0;`
`1244`	`1243`	`}`
`1245`	`1244`
`@@ -1296,6 +1295,7 @@ FCGI_API int fcgi_accept_request(fcgi_request *req)`
`1296`	`1295`
`1297`	`1296`	`client_sa = sa;`
`1298`	`1297`	`if (req->fd >= 0 && !fcgi_is_allowed()) {`
	`1298`	`+ fcgi_log(FCGI_ERROR, "Connection disallowed: IP address '%s' has been dropped.", fcgi_get_last_client_ip());`
`1299`	`1299`	`closesocket(req->fd);`
`1300`	`1300`	`req->fd = -1;`
`1301`	`1301`	`continue;`